Prep for Diva6 release

[EricHanLiu]

To-do list

• Unit tests
  • Test they work
  • Update them
    • issue Port Unit Tests to new framework #409
    • issue Testing: IIIFv2 and IIIFv3 support #412
    • issue Add code coverage tool to determine which additional unit tests should be written #422 (increase code coverage, write tests for plugins)
  • issue Unit tests failing for issue #441 #444 UNIT TESTS FAILING (related to issue Set diva-wrapper to take up full screen #441)
• Find and fix any outstanding bugs
  • issue Remove deprecated code from Diva 5 #350
  • issue disableScrollable() returns an error #392
  • issue Finish toolbar in fullscreen mode #376
  • issue PageDidLoad not firing #365
  • issue Error when one of the canvases in IIIF manifest has sizes below 128x128 #344
  • issue Expose jQuery-free API #324
  • issue Cannot exit fullscreen mode once the fullscreen button is clicked #400
  • issue Travis build fails when installing npm canvas #416
  • issue Handling no metadata in Metadata Plugin #425 (for metadata plugin)
  • issue Page Region dimensions are wrong #436
  • issue Zooming in on pages causes them to be cut off on the right #442
  • Page Label / Visible Pages stuff
    • issue Show labels instead of 'page numbers' #434
    • issue Book view and page indices #404
    • issue Resizing window (larger) doesn't adjust pageToolsOverlay #443
  • issue Problems with scrollbars #446
  • issue HTML in metadata is not rendered #447
  • issue Unnecessary calls to tile painting #380 - rendering issue, valid?
  • issue Set diva-wrapper to take up full screen #441 - viewport size change
• Update documentation
  • issue Don't reference PageDidLoad in docs #413
  • issue Add a README to develop #414 (README)
  • issue Update wiki and website #431, update wiki and website
• Update dependencies
  • Vulnerable
  • Outdated: issue Update packages to latest versions #410
• New features
  • issue New Plugin: IIIF Metadata Viewer #411
  • issue Support multiple views of a canvas #335
  • issue Parse IIIFv3 image manifests #418
  • issue Readd disabled toolbar features and enabling settings #421
  • issue Add filter composition queue to manipulation plugin #375 Manipulation Plugin
    • issue Add reset to manipulation plugin #438 Add reset
    • issue Secondary page shows for everything (Manipulation Plugin) #439 Secondary pages only once
    • issue Make main image centered and zoomable (Manipulation Plugin) #440 Make zoomable
    • issue Sharpness filter breaks #445 Sharpness Filter
    • issue Make threshold filter a different section #448 Threshold filter
    • issue Implement Rotate in manipulation plugin #450 rotate
    • issue Double-click does not zoom in manipulation plugin #451 dbl click zoom
    • issue Add close 'X' in manipulation plugin #452 close button
    • issue Add 'mirror' controls in manipulation plugin #453 mirror controls
    • issue Implement saturation, gamma, color channel filters #449 new filters
    • issue Implement (better) mobile compatibility for manipulation plugin #461 mobile
  • issue Reenable highlight plugin (as toolbar plugin) #432 highlight plugin - NOT FOR INITIAL RELEASE
  • issue Show 'secondary' images on a canvas #415 secondary images tool - NOT FOR INITIAL RELEASE
• Final preparations for release (after other issues are done)
  • issue Add Diva v6.0 to CDNJS #374, add to CDNJS (should only be done after the release is ready)
  • add latest Diva to npm
  • create release package
  • update release packages on site and wiki

PR #437 contains a lot of changes, accepted!

[EricHanLiu]

Fixed JSHint syntax issues and added proper Babel preset for Webpack compiling

[EricHanLiu]

None of the unit tests work on master or develop-diva6

edit: they work now with some tinkering

[EricHanLiu]

Dependencies updated

gulp -> 4.0.0
webpack -> 4.14.0
webpack-dev-server -> 3.1.4
mocha -> 5.2.0
babel-loader -> 7.1.4

[ahankinson]

As this release is imminent:

1. Merge your commits on this branch back to develop-diva6
2. Merge those commits from develop-diva6 to develop
3. Base your changes going forward on the develop branch.

There is no need to keep so many branches around.

[EricHanLiu]

Everything merged into develop

[ahankinson]

OK. You should probably break out the other checkboxed to-dos into specific issues.

[EricHanLiu]

reminder to fix event listener issue on fullscreen mode

[EricHanLiu]

Issue #434 and #404 are awaiting PR #435

Issue #375 is being done on the filter queue branch

[EricHanLiu]

Release should be ready

[EricHanLiu]

pr #466

[EricHanLiu]

This isn't being automatically added to CDNJS based on the git release tag (which it says it should be doing)

[EricHanLiu]

Closing this in favour of the existing open issues for CDNJS and cantus ultimus testing. Other issues will be relative to a new minor release