Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect MEI on Salzinnes 021v #4

Open
dchiller opened this issue Jun 15, 2022 · 7 comments
Open

Incorrect MEI on Salzinnes 021v #4

dchiller opened this issue Jun 15, 2022 · 7 comments
Assignees

Comments

@dchiller
Copy link
Contributor

dchiller commented Jun 15, 2022

In the Salzinnes 021v MEI file , there is an error starting at approx line 1091

<syl xml:id="m-ce05e6b8-ff39-44a4-8884-ac30d2edd73f" facs="#m-a531051b-d61d-4d8c-bf99-8697a8c0de4f">ha</syl>
<neume xml:id="neume-0000001783377858">
<nc xml:id="m-dec6ae00-c355-471c-9849-6c7c0643486c" facs="#m-d3976e6e-be0e-4471-bb82-4aec63647c06" oct="3" pname="c"/>
<nc xml:id="m-0f301276-6fee-49f3-a372-48c4ade43e5f" facs="#m-57aced04-c971-4f92-b737-db5ed44ef09e" oct="2" pname="b"/>
</neume>
</syllable>
<syllable xml:id="syllable-0000001798291927">
<neume xml:id="neume-0000001389158530">
<nc xml:id="nc-0000001183575245" facs="#zone-0000000750780960" oct="3" pname="c"/>
<nc xml:id="nc-0000001834528275" facs="#zone-0000000901769413" oct="3" pname="d"/>
</neume>
<syl xml:id="syl-0000000163807375" facs="#zone-0000001842931566">bet</syl>
<custos facs="#m-707e422a-cfa9-4724-a1ef-1672d6f07256" oct="3" pname="e" xml:id="m-ff01b5f7-e6ba-4c06-9895-8fdef911d42f"/>
<sb n="1" facs="#m-c7d4d537-54fa-4536-9ecb-cf23b8b4f904" xml:id="m-ac0e24e0-5924-4140-a447-9ad0c5b55050"/>
<clef xml:id="m-6dc619c0-d5c5-4582-8ea8-19d1855ad802" facs="#m-b09e776d-760b-4bc6-bb29-86778a4b2789" shape="C"/>
<neume xml:id="neume-0000000789277338">
<nc xml:id="nc-0000001077583390" facs="#zone-0000001569579923" oct="3" pname="b" ligated="true"/>
<nc xml:id="nc-0000002128333463" facs="#zone-0000000721477112" oct="3" pname="a" ligated="true"/>
<nc xml:id="nc-0000001561871581" facs="#zone-0000001589281347" oct="3" pname="b"/>
<nc xml:id="nc-0000001066501510" facs="#zone-0000001591477022" oct="4" pname="c"/>
<nc xml:id="nc-0000001400689878" facs="#zone-0000001417105391" oct="3" pname="b"/>
</neume>
</syllable>
<clef xml:id="clef-0000000601608529" facs="#zone-0000000738183959" shape="C" line="2"/>
<syllable xml:id="syllable-0000001881496700">
<neume xml:id="neume-0000001969715953">
<nc xml:id="nc-0000000545225958" facs="#zone-0000000451458188" oct="3" pname="a"/>
<nc xml:id="m-4366c694-f037-4de7-8b79-ee0be0e8be05" facs="#m-e21255ac-d11c-4eff-9a34-4794ffe810d3" oct="3" pname="g"/>
</neume>
<syl xml:id="syl-0000002011606955" facs="#zone-0000001997542083">fi</syl>
<neume xml:id="m-1a6534bd-a6fb-431f-be51-2934b9a16e2a">
<nc xml:id="m-d8cafd61-5cad-4410-8090-b80164698d0c" facs="#m-f8956987-5d07-41e0-b08f-b199ba47de64" oct="3" pname="a"/>
<nc xml:id="m-16af563c-83e9-4dd6-aa2e-9195a22d9e38" facs="#m-026b1837-0055-4a55-84bd-3e9918ae8adf" oct="3" pname="b" ligated="true"/>
<nc xml:id="m-4514c03b-b429-4053-8560-d2c308147934" facs="#m-bbad69f4-d72c-4598-b592-b4a3f785f562" oct="3" pname="a" ligated="true"/>
<nc xml:id="m-aefa5e2f-9910-4945-835e-f73d618643c2" facs="#m-f6608fb3-e2cd-4944-b34f-71a2e2da36bf" oct="3" pname="b"/>
</neume>
</syllable>

This section of the MEI is included in this part of the image (see end of first shown staff to beginning of the second shown staff):
image

This was discovered because the bounding boxes associated with neume components on lines 1107 and 1109 have the exact same coordinates, but the neume components are different.

@napulen
Copy link
Member

napulen commented Jun 15, 2022

Including experts here so you can take a look. If you are planning to upload files with the correction, please don't do it yet. Let's first coordinate on the best workflow to curate the production_mei_files. But your input would be very valuable 😃.

@annamorphism
Copy link

It's also not the right note names, which is strange... Going to put it in Neon to take a look here.

@napulen
Copy link
Member

napulen commented Jun 15, 2022

Thank you @annamorphism! Feel free to play around with the file and see what the error is about. We will provide a new set of MEI files that have automatic corrections in them applied. Presumably, we would like you to use those new files in Neon whenever you are finalizing your corrections/revisions. That'd result in a much cleaner production set of files. The new MEI files will be added to this repository.

@annamorphism
Copy link

Something very weird is going on here. Several of the pitches are mislabeled (but showing up in the spot they are labeled as); others are mislabelled AND in the wrong spot (as though there were e.g. a G2 clef).
image
And pulling down one of the high-up syllables to the right spot affects all five affected syllables (very strange) AND they are named as if by a G2 clef. Plus there is a clef on line 1105 with no line that doesn't show up on the page...

@JoyfulGen
Copy link

I've also played around with this and I think the problem is the invisible clef in line 1105 @annamorphism mentioned. The behaviour in the screenshot above is really similar to what we found in issue DDMAL/Neon#650, where having a clef within a syllable makes the neumes behave really weirdly. In this case, the behaviour is even weirder, because that clef has no line, so it doesn't... exist? This explains the pitches, because the default line for a clef is line 1. It also explains why, even when I deleted the offending neumes, putting them back in didn't solve anything, because the invisible clef was still busy with its shenanigans.

I removed that clef in the MEI and uploaded the file again, and the problem was gone. I have no idea how an invisible clef came to be, but I don't think this will be a big problem, especially when DDMAL/Neon#840 is implemented.

@annamorphism
Copy link

@JoyfulGen I tried playing around with it too, and agree that the issue has to do with the clef being inside a syllable. I'm not even sure how it came to be--the syllable should by rights be a linked syllable with precedes and follows, but it isn't, so I can't reproduce the exact situation. Maybe this was being corrected when linked syllables were being altered in some way?

I do think I know how the invisible clef got to be there--it's a case of DDMAL/Neon#686 . What's interesting about this special case is that the offending clef gets ignored when rendering the MEI files (so it's also a case of DDMAL/Neon#650 means the glyphs would have been in the right place when the corrector downloaded the MEI, and didn't show up in the wrong place until we re-uploaded it.

However, all of this is, it seems, just extra problems on top of the one that @dchiller posted, namely the shared coordinates of the two neumes. What's a little weird here is you would expect the neume components with the shared coordinates to be in the same place, but they aren't. Even after the weird clef is manually deleted, here they are as separate neumes:
image

but in the MEI file they (still) have identical coordinates:
image

If you take out the ligature, though, they bounce over to the right!
image
If you try to ligature them again, they don't SEEM to do anything at first (but actually a separate neume component has appeared in the middle)
image
but if you move one of the other neumes out of the way, our ligature appears:
image

What's also quite strange is that by rights this ligature shouldn't exist in the first place. The x-coordinate of the first neume in the ligature is to the right of the second; meanwhile the y-coordinate of neume no.1 should be about a third below neume no.2, not (as labelled) a half step above.

How did this happen? The mystery deepens....

@annamorphism
Copy link

Now, what would happen if we were simply to delete one of the neumes with the duplicated coordinates?

If it's the one outside the ligature (the first zone defined but the third of the neume components) things are basically OK. We get this gaptoothed fournote neume in orange:
image

It still does something weird with respect to the ligature:
image

The pitches are a little weird, too: even though I manually deleted the line0 clef, the new one doesn't seem to kick in until after the orange guy, so the pitches say F4E4G4F4 and then start with A3G3 on the new syllable. Still, it's nothing that can't be fixed by dragging everybody to the right place.
image

BUT if we decided to delete the other of the duplicated neumes (ie the second defined zone; the component itself is the first half of the ligature) things get weirder. We again have a gaptoothed orange guy here with the last two pitches labeled G4F4, but weirdly the first two are E4 and F4 despite showing up on the same line.
image
If we drag lil "E4" around, he keeps popping back to the same location on the page but with new pitch names in the MEI (here he is as E0):
image

If we ignore that and try to insert the missing neume component anyway, it eventually decides it would like to be at the same y value (but not x value) of the new neume component:
image
That is, unless you can get it to decide it is at a pitch higher than the one to its right, in which case you can sometimes convince it to be the left half of a ligature:
image

All of this is pretty weird; the point is that in this file it does seem to make a difference which duplicated neume we decide to delete. On the other hand, I have no idea how the problems of this file came about in the first place, so we shouldn't see issues like this too often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants