Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add universal binary support for Apple M1 architectures #2

Open
DominikDeak opened this issue Jul 20, 2021 · 14 comments
Open

Add universal binary support for Apple M1 architectures #2

DominikDeak opened this issue Jul 20, 2021 · 14 comments
Labels
Bug Something isn't working

Comments

@DominikDeak
Copy link
Member

The BuildDarwin.sh should use the following CMake architecture environment variables:

      -D CMAKE_OSX_ARCHITECTURES="arm64;x86_64" \

The Qt library also needs to be updated for universal binary support.

@DominikDeak DominikDeak added the Bug Something isn't working label Jul 20, 2021
@shukenmg
Copy link

any update on this? thanks.

@DominikDeak
Copy link
Member Author

DominikDeak commented Oct 12, 2021

any update on this? thanks.

Not yet unfortunately. The challenge is to rebuild Qt5 libraries on the Apple Silicon (arm64) architecture. As far as I'm aware, Qt5 build system is not functional on M1, and official support for it was introduced on Qt6. Synergy does not build with Qt6, as far as I'm aware. It's in the too hard basket for now, but I'll keep this issue open as a reminder in case the situation changes.

@shukenmg
Copy link

shukenmg commented Oct 24, 2021

Ok cool, i guess for now the x86 build should run under Rosetta 2?

@shukenmg
Copy link

Also, it seems that symless added a build workflow for M1
https://github.com/symless/synergy-core/pull/7098

@DominikDeak
Copy link
Member Author

DominikDeak commented Oct 26, 2021

Ok cool, i guess for now the x86 build should run under Rosetta 2?

Yes, it seems to run fine. I'm using the x86 build on the M1 on a daily basis.

Also, it seems that symless added a build workflow for M1 symless/synergy-core#7098

Cheers, i'll take a closer look when i have the time.

@Qerope
Copy link

Qerope commented May 10, 2022

Seems like the native support has been added since 1.14.2 it would be great if you could upload the native version too.

@jamuwu
Copy link

jamuwu commented Jun 29, 2022

bump, perhaps there are updates on this?

@seakrebel
Copy link

any updates on this? would be great to have arm64 (m1) binaries

@agungrbudiman
Copy link

agungrbudiman commented Jan 20, 2023

try my binary, tested on macOS 12.6.1. faster launch time and smaller memory usage compared to x86_64 binary.

@DominikDeak
Copy link
Member Author

Hey everyone, looks like the latest release will build natively for M1. You can get it here:

https://github.com/DEAKSoftware/Synergy-Binaries/releases/tag/1.14.6.13-snapshot

@seakrebel
Copy link

Thank you for the M1 build, however it doesn't work as expected. It says the app is damaged and should be moved to trash. This kind of error is already known to happen for some apps compiled for M1, and can normally be fixed with xattr -cr /path/to/app.app but unfortunately this didn't work for me with this app. I also tried a clean install of the app (by removing the leftover files from previous version) but this didn't help either.

After doing xattr -cr to the app, the error is different and says "Synergy quit unexpectedly". There is also a crash log which I can provide if needed.

@DominikDeak
Copy link
Member Author

can you provide the crash log?

@agungrbudiman
Copy link

Thank you for the M1 build, however it doesn't work as expected. It says the app is damaged and should be moved to trash. This kind of error is already known to happen for some apps compiled for M1, and can normally be fixed with xattr -cr /path/to/app.app but unfortunately this didn't work for me with this app. I also tried a clean install of the app (by removing the leftover files from previous version) but this didn't help either.

After doing xattr -cr to the app, the error is different and says "Synergy quit unexpectedly". There is also a crash log which I can provide if needed.

Try running this codesign --force --deep --sign - /Applications/Synergy.app.

@seakrebel
Copy link

@agungrbudiman This worked indeed. Thank you!
I hope it's now at least more clear where the error comes from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants