From 53fc85cce5b26cd18fb42f6b5360ddf95d5193b2 Mon Sep 17 00:00:00 2001 From: Serkan Sozer Date: Fri, 4 Sep 2020 16:52:13 +0100 Subject: [PATCH] AB#43311 --- .vscode/launch.json | 2 +- README.md | 2 +- angular.json | 3 +- e2e/protractor.conf.js | 4 +-- .../how-it-works/how-it-works.component.css | 4 +++ .../how-it-works/how-it-works.component.html | 8 ++--- .../footer/footer.component.html | 6 ++-- .../metric/em-table/em-table.component.html | 2 +- .../metric/em-table/em-table.component.scss | 2 +- src/app/metric/metric.component.html | 30 +++++++++++----- src/app/metric/metric.component.scss | 4 +++ src/app/metric/metric.component.ts | 15 +++++++- src/assets/images/help-icon-2x.png | Bin 0 -> 653 bytes src/assets/images/help-icon.png | Bin 0 -> 382 bytes .../images/icon-file-download-small.png | Bin 0 -> 254 bytes src/assets/images/icon-file-download.png | Bin 0 -> 118 bytes src/assets/images/icon-print.png | Bin 0 -> 1185 bytes src/styles.scss | 33 +++++++++++++++--- 18 files changed, 87 insertions(+), 28 deletions(-) create mode 100644 src/assets/images/help-icon-2x.png create mode 100644 src/assets/images/help-icon.png create mode 100644 src/assets/images/icon-file-download-small.png create mode 100644 src/assets/images/icon-file-download.png create mode 100644 src/assets/images/icon-print.png diff --git a/.vscode/launch.json b/.vscode/launch.json index bc7d723..4c0cfff 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -8,7 +8,7 @@ "type": "chrome", "request": "launch", "name": "Launch Chrome", - "url": "http://localhost:4200", + "url": "http://localhost:4201", "webRoot": "${workspaceFolder}" } ] diff --git a/README.md b/README.md index 87dd4e5..0f5e840 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,7 @@ Run `npm install` to update all packages required locally. ## Development server -Run `ng serve` for a dev server. Navigate to `http://localhost:4200/`. The app will automatically reload if you change any of the source files. +Run `ng serve` for a dev server. Navigate to `http://localhost:4201/`. The app will automatically reload if you change any of the source files. ## Code scaffolding diff --git a/angular.json b/angular.json index 7c199fd..5bf3ae4 100644 --- a/angular.json +++ b/angular.json @@ -93,7 +93,8 @@ "serve": { "builder": "@angular-devkit/build-angular:dev-server", "options": { - "browserTarget": "app:build" + "browserTarget": "app:build", + "port": 4201 }, "configurations": { "production": { diff --git a/e2e/protractor.conf.js b/e2e/protractor.conf.js index 7c798cf..d0f5665 100644 --- a/e2e/protractor.conf.js +++ b/e2e/protractor.conf.js @@ -16,7 +16,7 @@ exports.config = { browserName: 'chrome' }, directConnect: true, - baseUrl: 'http://localhost:4200/', + baseUrl: 'http://localhost:4201/', framework: 'jasmine', jasmineNodeOpts: { showColors: true, @@ -29,4 +29,4 @@ exports.config = { }); jasmine.getEnv().addReporter(new SpecReporter({ spec: { displayStacktrace: true } })); } -}; \ No newline at end of file +}; diff --git a/src/app/how-it-works/how-it-works.component.css b/src/app/how-it-works/how-it-works.component.css index e69de29..7ae303d 100644 --- a/src/app/how-it-works/how-it-works.component.css +++ b/src/app/how-it-works/how-it-works.component.css @@ -0,0 +1,4 @@ +.italic { + font-weight: normal; + font-style: italic; +} diff --git a/src/app/how-it-works/how-it-works.component.html b/src/app/how-it-works/how-it-works.component.html index 7f6da90..a16252f 100644 --- a/src/app/how-it-works/how-it-works.component.html +++ b/src/app/how-it-works/how-it-works.component.html @@ -5,12 +5,12 @@

Introduction

    -
  1. What is the efficiency metric ranking? +
  2. The efficiency metric

    The metric provides an indication of a schools efficiency compared to 49 statistically similar schools based on certain characteristics.

  3. How it is calculated -

    We divide a school's progress score (KS2 or Progress 8) by their per pupil expenditure which allows us to rank the 50 schools and find a their rank. - Progress score / Expenditure per pupil = Efficiency Metric Ranking +

    We divide a school's progress (KS2 or Progress 8) by their per pupil expenditure which gives us a score which allows us to rank the 50 schools. + KS2 progress or Progress 8 / Expenditure per pupil = Efficiency metric score

  4. What you should do with the information @@ -29,7 +29,7 @@

    Introduction

    Back diff --git a/src/app/layouts/gov-uk-layout/footer/footer.component.html b/src/app/layouts/gov-uk-layout/footer/footer.component.html index 9e710f8..195ef9c 100644 --- a/src/app/layouts/gov-uk-layout/footer/footer.component.html +++ b/src/app/layouts/gov-uk-layout/footer/footer.component.html @@ -23,10 +23,8 @@

    Support links

    5. - diff --git a/src/app/metric/em-table/em-table.component.html b/src/app/metric/em-table/em-table.component.html index 24b64c5..3f7c3a3 100644 --- a/src/app/metric/em-table/em-table.component.html +++ b/src/app/metric/em-table/em-table.component.html @@ -75,7 +75,7 @@
    - See ways to improve your school's efficiency metric ranking + See tools to improve your school's efficiency
    diff --git a/src/app/metric/em-table/em-table.component.scss b/src/app/metric/em-table/em-table.component.scss index 106c7aa..7987c53 100644 --- a/src/app/metric/em-table/em-table.component.scss +++ b/src/app/metric/em-table/em-table.component.scss @@ -159,7 +159,7 @@ padding: 5px; a{ - font-size: 14px; + font-size: 16px; font-weight: bold; } } diff --git a/src/app/metric/metric.component.html b/src/app/metric/metric.component.html index 06995a0..e29ac09 100644 --- a/src/app/metric/metric.component.html +++ b/src/app/metric/metric.component.html @@ -1,8 +1,8 @@ - +
    -
    -

    Efficiency Metric Ranking

    +
    +

    Efficiency Metric Ranking

    Results for @@ -10,6 +10,19 @@

    Efficiency Metric Ranking

    +
    +
    + + + Download page + + + + Print page + +
    +
    +
    @@ -26,14 +39,15 @@

    Efficiency Metric Ranking

    -
    +
    -

    Efficiency metric next steps

    -
    diff --git a/src/app/metric/metric.component.scss b/src/app/metric/metric.component.scss index 5cdc0de..a63f8f0 100644 --- a/src/app/metric/metric.component.scss +++ b/src/app/metric/metric.component.scss @@ -39,3 +39,7 @@ } } +.bm-button { + width: 100%; + font-size: 16px; +} diff --git a/src/app/metric/metric.component.ts b/src/app/metric/metric.component.ts index 78b808d..2cd9ee5 100644 --- a/src/app/metric/metric.component.ts +++ b/src/app/metric/metric.component.ts @@ -1,5 +1,5 @@ import { EmdataService } from '../core/network/services/emdata.service'; -import { ActivatedRoute } from '@angular/router'; +import { ActivatedRoute, Router } from '@angular/router'; import { Component, OnInit, TemplateRef } from '@angular/core'; import { EMModel } from 'app/Models/EMModel'; import { BsModalService, BsModalRef } from 'ngx-bootstrap/modal'; @@ -15,6 +15,7 @@ export class MetricComponent implements OnInit { modalRef: BsModalRef; constructor( + private router: Router, private route: ActivatedRoute, private modalService: BsModalService, private emDataService: EmdataService) { @@ -35,4 +36,16 @@ export class MetricComponent implements OnInit { openModal(template: TemplateRef) { this.modalRef = this.modalService.show(template, {animated: false, class: 'sfb-modal-dialog'}); } + + onDownload() { + + } + + onPrintPage() { + window.print(); + } + + onGotoBenchmark() { + this.router.navigate(['efficiency-metric/comparison-type/', this.urn, this.model.name]); + } } diff --git a/src/assets/images/help-icon-2x.png b/src/assets/images/help-icon-2x.png new file mode 100644 index 0000000000000000000000000000000000000000..399863332a0549cbe80ba64ca950a81056a88682 GIT binary patch literal 653 zcmV;80&@L{P)6q5P|OD!NpM;Aq0C@o~r$@Dyh}oGb2e@Yq2MUG9`e5ei<`t0MG&Gtd_T3 z^M?Qu$~*$709*k)U|&oC8UU@;^3P#FLYX=eh!dFAvW@~otlT`Z#Kr)iao0>R?+O1=O(Tn!k1D z_g;@4m8?6^zgUKb1AuzQGb+}Pm%SRV84}8@Zx!Vc#%DlJkrQMmpSio>=E}s^b?p(# zQ~-X&WUSRPowKZo*^a9aa>X$uW0z^)Zk$){9n%{?R7;u<1k}vMHCa$yA1ndUt!H_g zO&lp3EFBqm^V?SI@!nkD>7vM98WKmA^mL|~-Wv?tTxno_Cr=G@<>~+L=a@S@ST)?a nX*Zx1xcNyh_dF;>Kk2;!Bjq0Sea@{-00000NkvXXu0mjfPFEYn literal 0 HcmV?d00001 diff --git a/src/assets/images/help-icon.png b/src/assets/images/help-icon.png new file mode 100644 index 0000000000000000000000000000000000000000..b5d087adad0df93deb30896df17ec269d990a2e4 GIT binary patch literal 382 zcmV-^0fGLBP)Fc3wbnA}4LaR;FT(?Q^>gHbwg2XQAx2Xh6N zkPe`NP=Z~7a#<3gAVMa8hCwU7zV`1TDd!wMRMn(_k>{B?2A~FNXZ3Bi&KFWuQwZ^q zb=(2ttnQ|X#1k<Fo3DKG|^3_u>%K{Bs_ zD%fzBNKr#O#U!GtrchOrdEbt**tcmEhf5#nP9at*--3vDz>Cj+SP((xK7#Z|FHS># zvY|r*kU6V+uesuhTDWJ@YrbI;-nh*JPqxu^HMaCy^ib c(SI(sPnoQO7NJeO_5c6?07*qoM6N<$f{+iPu>b%7 literal 0 HcmV?d00001 diff --git a/src/assets/images/icon-file-download-small.png b/src/assets/images/icon-file-download-small.png new file mode 100644 index 0000000000000000000000000000000000000000..30602622c5079b51003d36a1c586253ad75beda2 GIT binary patch literal 254 zcmeAS@N?(olHy`uVBq!ia0vp^{6H+i!3HFQj;9L&DaPU;cPEB*=VV?2IV|apzK#qG z8~eHcB(eheoCO|{#S9F5M?jcysy3fAP;j!Ri(`m||Jx~sT+WI-ZOMWz`Y$B!9KCz< zHAfZ0MP|-**OustoXY;l8+(i2sjhi{vr6O9JDk~XYYHM;FXzl&I^{wX^Yc6VA~_hh zhH)sqnJswE@@a6|F^Q+|>uwm=e^%R{B$s^W>Z`){wwy~ve9s8pIKQ|2LX>mQ$FRe_ y4NA{>mQLyCfADpR&{-2Xj^s0^PgTkrtbc#eU*J&A(F~yT7(8A5T-G@yGywoBlV1-2 literal 0 HcmV?d00001 diff --git a/src/assets/images/icon-file-download.png b/src/assets/images/icon-file-download.png new file mode 100644 index 0000000000000000000000000000000000000000..02f769d3d83b0221d21e3c46e54815eab517f24e GIT binary patch literal 118 zcmeAS@N?(olHy`uVBq!ia0vp^azL!k$P6Tvy0cn<6kC8#h%1l=f~Dy@&jTsOk|4ie z28U-i(tsQ}PZ!4!j_Bkc|NqxBGxH^#TcFh7z~;2!|NsB&jtmU#GR;iA+>eAo+C5$U KT-G@yGywq5VjhA3 literal 0 HcmV?d00001 diff --git a/src/assets/images/icon-print.png b/src/assets/images/icon-print.png new file mode 100644 index 0000000000000000000000000000000000000000..d6b1372511b3a430c19744d89d0693e029a01676 GIT binary patch literal 1185 zcmbVL%WKp?7>|^KmR6|HgNiyv>x*WS$!0eXx|Vgb)kU|K-7W1!Fq_P_q0Pf&>ZS!B zRK)6`e}SmrMLmd*i(2r7AVLvADfmQG5HA(P$EmK9ZMS+TJvfkjGv9o_@B7X7INjZ~ zyQyJK14U6ynLTQb$gSktyu6P56JMTRCSo;C_u;%#!ez}vRMK#Y2xKg+ALWo{j2wD` z+9|3oFbjRSFS}3C9V?=RHj%(`37VqXI|5hJ2N4EE)Nk4e`s?I98kk0c?u})+teZju z=AKaxkqnfrYRJ0&B?jl^{V^{VHT1s#zLTP4HlXo+H(l?FK2w zLm(E3Gdhe)K$IgeCQH1~26zs}Sx#o5z;ICEWQBuZe$gbFXOxtj+BqMKoD%c^#;(G$ z<#IVvjz%1>pM|n4vmDRzJVPuPf5gUGz}Wt#ng)_!5cMQjfF&akJGdXzTRz$AA|2MP@d z8)d&|lA>rss-q8E$i^8pL6e(^VH$)!5=2=6>||5yrji>PT-j$ zZ-|UgEFq>S@Nq_p%h6H{3QRUkYdAj`KNtqD$^CxKYrFRq(nQiUJw84jjYg-Yre$CnqbF%E;qjZwqv7Mz^2?T2_nJR7!{!IA6WkWn9=kKuwzorW z(`O$ZI=}4P+q(Kw7x4Jl#k=pP->z$UbFH$m|I+QsmDk3Nn+MKM=dU-`o!ol{JaTum zUh!56+kYHA`?3A|L}B9Hv0tBep8fq~^u*KK>o)g3XuVJ2n=S8;-1_;H(4jKvF7@iJ HgJXXHQTUP1 literal 0 HcmV?d00001 diff --git a/src/styles.scss b/src/styles.scss index 04257f8..35707f3 100644 --- a/src/styles.scss +++ b/src/styles.scss @@ -19,6 +19,12 @@ a{ .a-button{ text-decoration: none; + &:visited{ + color: initial!important; + } + &:hover{ + text-decoration: none; + } } .back-button{ @@ -30,7 +36,7 @@ a{ } .small-icon{ - width: 20px; + //width: 20px; margin-right: 5px; } @@ -58,7 +64,7 @@ a{ .highlight { background-color: #d53880; display: inline; - padding: 5px 5px; + padding: 2px 5px; span { color: white; @@ -83,7 +89,7 @@ span.table-cell-highlight { background-color: #d53880; display: inline; - padding: 6px 8px 6px 8px; + padding: 2px 5px; color: white; line-height: 1.8em; font-weight: bold; @@ -92,7 +98,7 @@ span.table-cell-highlight { a.table-cell-highlight { background-color: #d53880; display: inline; - padding: 6px 8px 6px 8px; + padding: 2px 5px; color: white; text-decoration: none; font-weight: bold; @@ -231,3 +237,22 @@ span.table-cell-highlight { margin-top: 1em; display: block; } + +@media print { + .show-in-print { + display: block!important; + } + + .hide-in-print { + display: none!important; + } + + .main-header{ + margin-top: 1em!important; + } + + .expand-in-print{ + width: 100%; + } + +}