Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wavetable VCO > Download Extra Wavetable Content Causes Ableton To Crash #674

Open
wyhinton opened this issue Jun 1, 2024 · 3 comments
Open

Comments

@wyhinton
Copy link

wyhinton commented Jun 1, 2024

Version

24.04

Plugin type

VST3

OS

Sonama 14.3.1 (23D60)

DAW / Host (if applicable)

Ableton 12.0.1

Description

New to cardinal so not sure if this is the correct place to raise an issue regarding a particular module or if it should be raised on that modules own repo. But as the title describes and as shown in video, clicking "Download Extra Wavetable Content" for the Wavetable VCO causes Ableton to crash. No particular context or setup is required to reproduce, seems like clicking it at any point causes the crash.

Screen.Recording.2024-05-31.at.5.57.42.PM.mov
@dromer
Copy link
Collaborator

dromer commented Jun 1, 2024

Hmm, on the standalone I see this in the console:

terminate called after throwing an instance of 'rack::Exception'
  what():  Unarchiver could not open archive /home/dreamer/Documents/SurgeXTRack/SurgeXT_ExtraContent.tar.zst: Failed to open '/home/dreamer/Documents/SurgeXTRack/SurgeXT_ExtraContent.tar.zst'
Aborted

The tricky thing is that we don't like Cardinal to connect to outside resources, but this module requires to be able to download from the internet: https://github.com/surge-synthesizer/surge-rack/blob/main/src/VCO.cpp#L102-L121

A work-around is to download this file manually and place it in the Documents/SurgeXTRack/ location (will be different based on your OS). Make sure to call it SurgeXT_ExtraContent.tar.zst as the downloaded file is called SurgeXTRack_ExtraContent.tar.zst

@falkTX
Copy link
Contributor

falkTX commented Jun 1, 2024

this module requires to be able to download from the internet: https://github.com/surge-synthesizer/surge-rack/blob/main/src/VCO.cpp#L102-L121

this is nasty errr. I understand why they do it, but this download will just freeze the UI on the main VCV Rack builds. Specially noticeable if the connection is slow.
Then it does not check if the download succeeded, it just tries to extract it.

I think best we can do here is to patch surge to display some text explaining what to do, with the link to the download and the also user folder.

@falkTX
Copy link
Contributor

falkTX commented Jun 1, 2024

or alternatively dont even show that menu option since it wont work on cardinal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants