Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in tet LUT #1289

Open
sandro-elsweijer opened this issue Oct 31, 2024 · 1 comment · May be fixed by #1290
Open

Bug in tet LUT #1289

sandro-elsweijer opened this issue Oct 31, 2024 · 1 comment · May be fixed by #1290
Labels
Bug For a bug in the Code priority: low Should be solved eventually workload: medium Would take a week or less

Comments

@sandro-elsweijer
Copy link
Collaborator

Bug report

Describe the bug
While removing code duplication I stumbled about a mismatch in the face orientation.
Which one is correct?

{ { 1, 2, 3 }, { 0, 2, 3 }, { 0, 1, 3 }, { 0, 1, 2 } }, /* tet */

const int t8_dtet_face_corner[4][3] = { { 1, 3, 2 }, { 0, 2, 3 }, { 0, 3, 1 }, { 0, 1, 2 } };

Estimated priority
Which of these is most applicable (remove the others):

"Priority: high" Should be solved as soon as possible

"Priority: medium" Should be solved within half a year

"Priority: low" Should be solved eventually

Additional context
Add any other context about the problem here.

@sandro-elsweijer sandro-elsweijer added Bug For a bug in the Code priority: low Should be solved eventually workload: medium Would take a week or less labels Oct 31, 2024
@sandro-elsweijer sandro-elsweijer linked a pull request Oct 31, 2024 that will close this issue
14 tasks
@sandro-elsweijer sandro-elsweijer linked a pull request Oct 31, 2024 that will close this issue
14 tasks
@sandro-elsweijer
Copy link
Collaborator Author

@Davknapp and I checked the LUTs manually and decided, that the ones from the eclass.c were the correct ones.
@holke Did we miss something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For a bug in the Code priority: low Should be solved eventually workload: medium Would take a week or less
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant