Bug: t8code 3.0.0. defines p4est version as 0.0.0.

[jmark]

Bug report

Describe the bug

t8code 3.0.0. tarball defines p4est version as 0.0.0. The result in p4est_config.h reads

[...]

/* Define to the full name and version of this package. */
#define P4EST_PACKAGE_STRING "p4est 0.0.0"

/* Define to the one symbol short name of this package. */
#define P4EST_PACKAGE_TARNAME "p4est"

/* Define to the home page for this package. */
#define P4EST_PACKAGE_URL ""

/* Define to the version of this package. */
#define P4EST_PACKAGE_VERSION "0.0.0"

/* Version number of package */
#define P4EST_VERSION "0.0.0"

/* Package major version */
#define P4EST_VERSION_MAJOR 0

/* Package minor version */
#define P4EST_VERSION_MINOR 0

/* Package point version */
#define P4EST_VERSION_POINT 0

To Reproduce

Create a tarball source code distribution of t8code via CMake.

Expected behavior

The actual used p4est version is 2.8.6.

[tim-griesbach]

I created the PR cburstedde/p4est#323 that should ensure that the version numbers inp4est_config.h are set correctly.

[jmark]

I created the PR cburstedde/p4est#323 that should ensure that the version numbers inp4est_config.h are set correctly.

@tim-griesbach Thank you very much for your fix!

[jmark]

Unfortunately, the fix in cburstedde/p4est#323 is only half the solution.

Now what is needed, is a version retrieval when p4est is compiled from a tarball distribution.

See cburstedde/p4est#325.