Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using regSquare function in partial valve models to improve robustness #118

Open
nieweber opened this issue May 10, 2023 · 0 comments
Open
Assignees
Labels
enhancement New feature or request p::FlowControl Concerns package FlowControl or Undirected.FlowControl wontfix This will not be worked on

Comments

@nieweber
Copy link
Contributor

nieweber commented May 10, 2023

Currently, the Modelica.Fluid.Utilities.regSquare function is not used in the valve models, but only in the FlowResistance. Adding the regSquare function could improve robustness in edge cases.

The default range, where the regularization starts (delta=0.01) leads to high deviations in the results in edge cases, when the valve is fully closed and the actual mass flow is much smaller than the reference mass flow. Future tests should investigate, how the robustness can be improved using the regSquare functions with different regularization ranges delta.

@nieweber nieweber added enhancement New feature or request p::FlowControl Concerns package FlowControl or Undirected.FlowControl labels May 10, 2023
@nieweber nieweber self-assigned this May 10, 2023
@nieweber nieweber added the wontfix This will not be worked on label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p::FlowControl Concerns package FlowControl or Undirected.FlowControl wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant