feat: streaming AI code review, copy to agent, faster prompt

DLhugly · DLhugly · commit 7534260e8095 · 2026-03-31T02:06:19.000+08:00
diff --git a/clif-pad-ide/src-tauri/src/commands/ai.rs b/clif-pad-ide/src-tauri/src/commands/ai.rs
@@ -518,31 +518,35 @@ pub struct CodeReviewResult {
 
 #[tauri::command]
 pub async fn ai_review_code(
+    window: tauri::Window,
     diff: String,
     staged_files: Vec<String>,
     model: String,
     api_key: Option<String>,
     provider: String,
-) -> Result<CodeReviewResult, String> {
+) -> Result<(), String> {
+    let app = window.app_handle().clone();
+    let label = window.label().to_string();
     let url = get_provider_url(&provider);
 
     // Truncate diff if too long for faster processing
-    let truncated_diff = if diff.len() > 8000 {
-        format!("{}...\n[Diff truncated for performance]", &diff[..8000])
+    let truncated_diff = if diff.len() > 6000 {
+        format!("{}...\n[Truncated]", &diff[..6000])
     } else {
         diff.clone()
     };
     
     let files_list = staged_files.join(", ");
+    // Shorter, faster prompt
     let prompt = format!(
-        r#"Review this code diff briefly. Files: {}
+        r#"Quick review of: {}
 
 {}
 
-Return JSON only:
-{{"suggestions":[{{"file":"path","line":N,"severity":"warning|info","title":"issue","description":"why"}}],"summary":"one sentence"}}
+List issues in this format:
+**file:line** (severity): description
 
-Only report real issues. Max 3 suggestions."#,
+Only real issues. Be brief."#,
         files_list, truncated_diff
     );
 
@@ -554,8 +558,8 @@ Only report real issues. Max 3 suggestions."#,
     let mut request_body = json!({
         "model": model,
         "messages": api_messages,
-        "stream": false,
-        "max_tokens": 800,
+        "stream": true,
+        "max_tokens": 500,
     });
 
     if provider == "openrouter" {
@@ -583,57 +587,71 @@ Only report real issues. Max 3 suggestions."#,
         }
     }
 
-    let response = req_builder
-        .json(&request_body)
-        .send()
-        .await
-        .map_err(|e| format!("Failed to send request: {}", e))?;
+    // Spawn streaming task
+    tokio::spawn(async move {
+        let response = match req_builder.json(&request_body).send().await {
+            Ok(resp) => resp,
+            Err(e) => {
+                let _ = app.emit_to(&label, "code_review_error", format!("Request failed: {}", e));
+                return;
+            }
+        };
 
-    if !response.status().is_success() {
-        let status = response.status();
-        let body = response.text().await.unwrap_or_default();
-        return Err(format!("API error {}: {}", status, body));
-    }
+        if !response.status().is_success() {
+            let status = response.status();
+            let body = response.text().await.unwrap_or_default();
+            let _ = app.emit_to(&label, "code_review_error", format!("API error {}: {}", status, body));
+            return;
+        }
 
-    let json: serde_json::Value = response
-        .json()
-        .await
-        .map_err(|e| format!("Failed to parse response: {}", e))?;
+        // Emit start event with files being scanned
+        let _ = app.emit_to(&label, "code_review_start", staged_files.clone());
 
-    let content = json["choices"][0]["message"]["content"]
-        .as_str()
-        .unwrap_or("{}");
-
-    // Parse the LLM response
-    let parsed: serde_json::Value = serde_json::from_str(content)
-        .unwrap_or_else(|_| json!({"suggestions": [], "summary": "Could not parse review response"}));
-
-    let suggestions: Vec<CodeReviewSuggestion> = parsed["suggestions"]
-        .as_array()
-        .map(|arr| {
-            arr.iter()
-                .filter_map(|s| {
-                    Some(CodeReviewSuggestion {
-                        file: s["file"].as_str()?.to_string(),
-                        line: s["line"].as_u64().map(|l| l as usize),
-                        severity: s["severity"].as_str().unwrap_or("info").to_string(),
-                        title: s["title"].as_str().unwrap_or("Issue").to_string(),
-                        description: s["description"].as_str().unwrap_or("").to_string(),
-                        suggestion: s["suggestion"].as_str().map(|s| s.to_string()),
-                    })
-                })
-                .collect()
-        })
-        .unwrap_or_default();
+        // Stream the response
+        let mut stream = response.bytes_stream();
+        use futures::StreamExt;
 
-    let summary = parsed["summary"]
-        .as_str()
-        .unwrap_or("Review complete")
-        .to_string();
+        let mut buffer = String::new();
+        let mut full_content = String::new();
+
+        while let Some(chunk_result) = stream.next().await {
+            match chunk_result {
+                Ok(chunk) => {
+                    let chunk_str = String::from_utf8_lossy(&chunk);
+                    buffer.push_str(&chunk_str);
 
-    Ok(CodeReviewResult {
-        files_scanned: staged_files,
-        suggestions,
-        summary,
-    })
+                    while let Some(newline_pos) = buffer.find('\n') {
+                        let line = buffer[..newline_pos].trim().to_string();
+                        buffer = buffer[newline_pos + 1..].to_string();
+
+                        if line.is_empty() || !line.starts_with("data: ") {
+                            continue;
+                        }
+
+                        let data = &line[6..];
+
+                        if data == "[DONE]" {
+                            let _ = app.emit_to(&label, "code_review_done", &full_content);
+                            return;
+                        }
+
+                        if let Ok(parsed) = serde_json::from_str::<serde_json::Value>(data) {
+                            if let Some(content) = parsed["choices"][0]["delta"]["content"].as_str() {
+                                full_content.push_str(content);
+                                let _ = app.emit_to(&label, "code_review_stream", content);
+                            }
+                        }
+                    }
+                }
+                Err(e) => {
+                    let _ = app.emit_to(&label, "code_review_error", format!("Stream error: {}", e));
+                    return;
+                }
+            }
+        }
+
+        let _ = app.emit_to(&label, "code_review_done", &full_content);
+    });
+
+    Ok(())
 }
diff --git a/clif-pad-ide/src/components/layout/RightSidebar.tsx b/clif-pad-ide/src/components/layout/RightSidebar.tsx
@@ -1,6 +1,6 @@
-import { Component, Show, For, createSignal, createMemo, lazy, Suspense } from "solid-js";
+import { Component, Show, For, createSignal, createMemo, lazy, Suspense, onCleanup } from "solid-js";
 import { projectRoot, openFile, openDiff, refreshFileTree } from "../../stores/fileStore";
-import { revealPath, renameEntry, deleteEntry, scanFilesSecurity, gitDiff, generateCommitMessage, getApiKey, aiReviewCode, type CodeReviewResult } from "../../lib/tauri";
+import { revealPath, renameEntry, deleteEntry, scanFilesSecurity, gitDiff, generateCommitMessage, getApiKey, aiReviewCode, onCodeReviewStart, onCodeReviewStream, onCodeReviewDone, onCodeReviewError } from "../../lib/tauri";
 import { securityEnabled, setSecurityResults, setSecurityShowModal, securityShowModal } from "../../stores/securityStore";
 import SecurityModal from "../security/SecurityModal";
 import ContextMenu, { type ContextMenuItem } from "../explorer/ContextMenu";
@@ -16,6 +16,7 @@ import type { GitLogEntry } from "../../types/git";
 import { FileRow, GitGraphRow, PlusIcon } from "../git";
 import { ResizeHandle, GitSyncButton, SidebarToolbarButton } from "../ui";
 import { settings } from "../../stores/settingsStore";
+import type { UnlistenFn } from "@tauri-apps/api/event";
 
 const FileTree = lazy(() => import("../explorer/FileTree"));
 
@@ -78,10 +79,11 @@ const RightSidebar: Component<{ onOpenFolder?: () => void; onOpenRecent?: (path:
   const [isDraggingGitSplitter, setIsDraggingGitSplitter] = createSignal(false);
   const [searchQuery, setSearchQuery] = createSignal("");
   const [isAiReviewing, setIsAiReviewing] = createSignal(false);
-  const [aiReviewResult, setAiReviewResult] = createSignal<CodeReviewResult | null>(null);
+  const [aiReviewContent, setAiReviewContent] = createSignal("");
   const [aiReviewExpanded, setAiReviewExpanded] = createSignal(true);
-  const [aiReviewAbortController, setAiReviewAbortController] = createSignal<AbortController | null>(null);
+  const [aiReviewFiles, setAiReviewFiles] = createSignal<string[]>([]);
   let gitSplitContainerRef: HTMLDivElement | undefined;
+  let aiReviewUnlisten: UnlistenFn | undefined;
 
   async function handleGenerateCommitMessage() {
     if (isGeneratingMsg() || stagedFiles().length === 0) return;
@@ -110,56 +112,75 @@ const RightSidebar: Component<{ onOpenFolder?: () => void; onOpenRecent?: (path:
   async function handleAiReview() {
     if (isAiReviewing() || stagedFiles().length === 0) return;
     setIsAiReviewing(true);
-    setAiReviewResult(null);
+    setAiReviewContent("");
     
-    const controller = new AbortController();
-    setAiReviewAbortController(controller);
-    
-    try {
-      const s = settings();
-      const model = s.aiModel || "anthropic/claude-sonnet-4";
-      const provider = s.aiProvider || "openrouter";
-      const apiKey = await getApiKey(provider);
+    const s = settings();
+    const model = s.aiModel || "anthropic/claude-sonnet-4";
+    const provider = s.aiProvider || "openrouter";
+    const apiKey = await getApiKey(provider);
 
-      const diff = await gitDiff(projectRoot() || "", undefined);
-      const stagedPaths = stagedFiles().map(f => f.path);
+    const diff = await gitDiff(projectRoot() || "", undefined);
+    const stagedPaths = stagedFiles().map(f => f.path);
 
-      const result = await aiReviewCode(diff, stagedPaths, model, apiKey, provider);
-      setAiReviewResult(result);
-      setAiReviewExpanded(true);
+    // Set up event listeners for streaming
+    const unlistenStart = await onCodeReviewStart((files) => {
+      setAiReviewFiles(files);
+    });
+    
+    const unlistenStream = await onCodeReviewStream((chunk) => {
+      setAiReviewContent(prev => prev + chunk);
+    });
+    
+    const unlistenDone = await onCodeReviewDone(() => {
+      setIsAiReviewing(false);
+    });
+    
+    const unlistenError = await onCodeReviewError((error) => {
+      console.error("AI review error:", error);
+      setAiReviewContent(prev => prev + `\n\n**Error:** ${error}`);
+      setIsAiReviewing(false);
+    });
+    
+    // Store unlisteners for cleanup
+    aiReviewUnlisten = () => {
+      unlistenStart();
+      unlistenStream();
+      unlistenDone();
+      unlistenError();
+    };
+    
+    setAiReviewExpanded(true);
+    
+    try {
+      await aiReviewCode(diff, stagedPaths, model, apiKey, provider);
     } catch (e) {
       console.error("Failed to run AI code review:", e);
-    } finally {
       setIsAiReviewing(false);
-      setAiReviewAbortController(null);
     }
   }
 
   function cancelAiReview() {
-    const controller = aiReviewAbortController();
-    if (controller) {
-      controller.abort();
-      setIsAiReviewing(false);
-      setAiReviewAbortController(null);
+    // Currently no backend cancel for this - just reset state
+    if (aiReviewUnlisten) {
+      aiReviewUnlisten();
     }
+    setIsAiReviewing(false);
+    setAiReviewContent(prev => prev + "\n\n*[Cancelled]*");
   }
 
   function copyAiReviewToAgent() {
-    if (!aiReviewResult()) return;
-    const result = aiReviewResult()!;
-    let text = `## AI Code Review\n\n**Files scanned:** ${result.files_scanned.join(", ")}\n\n`;
-    text += `**Summary:** ${result.summary}\n\n`;
-    if (result.suggestions.length > 0) {
-      text += `### Suggestions\n\n`;
-      for (const s of result.suggestions) {
-        text += `**${s.severity.toUpperCase()}**: ${s.file}${s.line ? `:${s.line}` : ""} - ${s.title}\n`;
-        text += `${s.description}\n`;
-        if (s.suggestion) text += `Suggestion: ${s.suggestion}\n`;
-        text += "\n";
-      }
-    }
+    const content = aiReviewContent();
+    if (!content) return;
+    
+    const text = `## AI Code Review\n\n**Files:** ${aiReviewFiles().join(", ")}\n\n${content}`;
     navigator.clipboard.writeText(text);
   }
+  
+  onCleanup(() => {
+    if (aiReviewUnlisten) {
+      aiReviewUnlisten();
+    }
+  });
 
   function handleGitSplitterMouseDown(e: MouseEvent) {
     e.preventDefault();
@@ -941,33 +962,30 @@ const RightSidebar: Component<{ onOpenFolder?: () => void; onOpenRecent?: (path:
 
                   {/* Expandable content */}
                   <Show when={aiReviewExpanded()}>
-                    <div class="px-2 py-1.5" style={{ "max-height": "150px", "overflow-y": "auto" }}>
-                      <Show when={isAiReviewing()}>
+                    <div class="px-2 py-1.5" style={{ "max-height": "200px", "overflow-y": "auto" }}>
+                      <Show when={isAiReviewing() && !aiReviewContent()}>
                         <div class="flex items-center gap-2 text-xs" style={{ color: "var(--text-muted)" }}>
                           <SpinnerIcon />
                           <span>Analyzing staged changes...</span>
                         </div>
                       </Show>
-                      <Show when={aiReviewResult()}>
-                        <div class="text-xs" style={{ color: "var(--text-muted)", "margin-bottom": "8px" }}>
-                          {aiReviewResult()!.summary}
+                      <Show when={aiReviewContent()}>
+                        <div 
+                          class="text-xs" 
+                          style={{ 
+                            color: "var(--text-primary)", 
+                            "white-space": "pre-wrap",
+                            "word-break": "break-word",
+                            "line-height": "1.5",
+                          }}
+                        >
+                          {aiReviewContent()}
                         </div>
-                        <Show when={aiReviewResult()!.suggestions.length > 0}>
-                          <For each={aiReviewResult()!.suggestions}>
-                            {(s) => (
-                              <div class="mb-2 p-1.5 rounded" style={{ background: "var(--bg-hover)", "font-size": "0.75em" }}>
-                                <div class="flex items-center gap-1" style={{ color: s.severity === "warning" ? "var(--accent-yellow)" : "var(--text-secondary)" }}>
-                                  <span style={{ "font-weight": 600 }}>{s.severity.toUpperCase()}</span>
-                                  <span style={{ color: "var(--text-muted)" }}>{s.file}{s.line ? `:${s.line}` : ""}</span>
-                                </div>
-                                <div style={{ color: "var(--text-primary)", "margin-top": "2px" }}>{s.title}</div>
-                              </div>
-                            )}
-                          </For>
+                        <Show when={!isAiReviewing()}>
                           <button
                             type="button"
                             onClick={copyAiReviewToAgent}
-                            class="w-full py-1 rounded text-xs transition-colors"
+                            class="w-full mt-2 py-1 rounded text-xs transition-colors"
                             style={{
                               background: "var(--accent-primary)",
                               color: "var(--accent-text, #fff)",
@@ -978,15 +996,10 @@ const RightSidebar: Component<{ onOpenFolder?: () => void; onOpenRecent?: (path:
                             Copy to Agent
                           </button>
                         </Show>
-                        <Show when={aiReviewResult()!.suggestions.length === 0}>
-                          <div class="text-xs" style={{ color: "var(--accent-green)" }}>
-                            No issues found in staged changes.
-                          </div>
-                        </Show>
                       </Show>
-                      <Show when={!isAiReviewing() && !aiReviewResult()}>
+                      <Show when={!isAiReviewing() && !aiReviewContent()}>
                         <div class="text-xs" style={{ color: "var(--text-muted)" }}>
-                          Stage files and click AI scan to review
+                          Click the AI button to analyze staged changes.
                         </div>
                       </Show>
                     </div>
diff --git a/clif-pad-ide/src/lib/tauri.ts b/clif-pad-ide/src/lib/tauri.ts
