Issue #3555 - Added feature for Org admins can show/hide the

Ethical_Issues fragment in plans project details page.
Co-authored-by: don-stuckey <[email protected]>

This feature was contributed to DMPonline by @don-stuckey.

Changes:
- These changes only kick in if enable_ethical_issues is enable in the
  application config.
- Added to Org model attribute in a migration
   add_ro_ethical_concerns  :boolean  default(true), not null
- Added a checkbox 'Add "Research outputs may have ethical concerns"
  field to "Project details" tab in plans' to app/views/orgs/_profile_form.html.erb.
- Added code to the Plan Project Details view to show or hide the Ethical
  Issues fragment.
- Added :add_ro_ethical_concerns to the strong params org_params for the
  Org controller.

Author: John Pinto

CHANGELOG.md

@@ -1,5 +1,7 @@
 # Changelog
 
+- Feature for Org admins can show/hide the ethical_issues field on plans [#3555](https://github.com/DMPRoadmap/roadmap/pull/3555).
+
 ## v5.0.2
 - Bump Ruby to v3.1.4 and use `.ruby-version` in CI
   - [#3566](https://github.com/DMPRoadmap/roadmap/pull/3566)

app/controllers/orgs_controller.rb

@@ -222,6 +222,7 @@ def org_params
           .permit(:name, :abbreviation, :logo, :contact_email, :contact_name,
                   :remove_logo, :managed, :feedback_enabled, :org_links,
                   :funder, :institution, :organisation,
+                  :add_ro_ethical_concerns,
                   :feedback_msg, :org_id, :org_name, :org_crosswalk,
                   :helpdesk_email,
                   identifiers_attributes: %i[identifier_scheme_id value],

app/models/org.rb

@@ -25,6 +25,7 @@
 #  region_id              :integer
 #  managed                :boolean          default(false), not null
 #  helpdesk_email         :string
+#  add_ro_ethical_concerns  :boolean        default(true), not null
 #
 # Foreign Keys
 #

app/views/orgs/_profile_form.html.erb

@@ -180,7 +180,37 @@
       </div>
     <% end %>
   </div>
+  <hr>
+  <%# Organisation Permissions block where super admin can add:
+    "Project details" tab in a plan
+  %>
+
+  <% org_perms_header_block = capture do %>
+    <h3>
+      <%= _('Organisation Permissions') %>
+    </h3>
+  <% end %>
+
+  <% add_ro_ethical_concerns_block = capture do %>
+    <div class="checkbox">
+      <%= f.label :add_ro_ethical_concerns do %>
+        <%= f.check_box :add_ro_ethical_concerns, { class: 'org_types', value: org.add_ro_ethical_concerns?  }, "true", "false" %>
+        <%= _('Add "Research outputs may have ethical concerns" field to "Project details" tab in plans') %>
+      <% end %>
+    </div>
+  <% end %>
 
+  <div class="row">
+    <% if current_user.can_super_admin? %>
+      <fieldset class="col-sm-8">
+        <%= org_perms_header_block %>
+        <%= add_ro_ethical_concerns_block %>
+      </fieldset>
+    <% elsif current_user.can_org_admin? %>
+      <%= org_perms_header_block %>
+      <%= add_ro_ethical_concerns_block %>
+    <% end %>
+  </div>
   <hr>
 
   <% if !org.new_record? %>

app/views/plans/_project_details.html.erb

@@ -102,7 +102,7 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
   </div>
 <% end %>
 
-<% if Rails.configuration.x.madmp.enable_ethical_issues %>
+<% ethical_issues_block = capture do %>
   <conditional>
     <div class="form-control mb-3">
       <div class="col-lg-8">
@@ -143,6 +143,16 @@ ethics_report_tooltip = _("Link to a protocol from a meeting with an ethics comm
   </conditional>
 <% end %>
 
+<% if Rails.configuration.x.madmp.enable_ethical_issues %>
+    <% if plan.ethical_issues == true %>
+      <%= ethical_issues_block %>
+    <% else %>
+      <% if current_user.org.add_ro_ethical_concerns? %>
+        <%= ethical_issues_block %>
+      <% end %>
+    <% end %>
+<% end %>
+
 <conditional>
   <div id="funder-org-controls" class="form-control mb-3">
     <div class="col-lg-8">

db/migrate/20250829093759_add_add_ro_ethical_concerns_to_orgs.rb

@@ -0,0 +1,6 @@
+class AddAddRoEthicalConcernsToOrgs < ActiveRecord::Migration[6.1]
+  def change
+    add_column :orgs, :add_ro_ethical_concerns, :boolean, default: true, null: false
+    Org.update_all(add_ro_ethical_concerns: true)
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.1].define(version: 2025_01_15_102816) do
+ActiveRecord::Schema[7.1].define(version: 2025_10_16_134521) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -276,6 +276,7 @@
     t.string "api_create_plan_email_subject"
     t.text "api_create_plan_email_body"
     t.string "helpdesk_email"
+    t.boolean "add_ro_ethical_concerns", default: true, null: false
     t.index ["language_id"], name: "fk_rails_5640112cab"
     t.index ["region_id"], name: "fk_rails_5a6adf6bab"
   end