Made rubocop happy

Author: benjaminfaure

app/controllers/api/v0/base_controller.rb

@@ -56,7 +56,7 @@ def update
       #
       # Returns Object
       def retrieve_resource
-        instance_variable_get("@#{resource_name}")
+        instance_variable_get(:"@#{resource_name}")
       end
 
       # The allowed parameters for searching. Override this method in each API
@@ -98,13 +98,13 @@ def resource_name
       # the method "#{resource_name}_params" to limit permitted
       # parameters for the individual model.
       def resource_params
-        @resource_params ||= send("#{resource_name}_params")
+        @resource_params ||= send(:"#{resource_name}_params")
       end
 
       # Use callbacks to share common setup or constraints between actions.
       def define_resource(resource = nil)
         resource ||= resource_class.find(params[:id])
-        instance_variable_set("@#{resource_name}", resource)
+        instance_variable_set(:"@#{resource_name}", resource)
       end
 
       def authenticate

app/controllers/application_controller.rb

@@ -54,11 +54,11 @@ def current_locale
   def store_location
     # store last url - this is needed for post-login redirect to whatever the user last
     # visited.
+    # don't store ajax calls
     unless ['/users/sign_in',
             '/users/sign_up',
             '/users/password',
-            '/users/invitation/accept'].any? { |ur| request.fullpath.include?(ur) } \
-    || request.xhr? # don't store ajax calls
+            '/users/invitation/accept'].any? { |ur| request.fullpath.include?(ur) } || request.xhr?
       session[:previous_url] = request.fullpath
     end
   end

app/controllers/concerns/versionable.rb

@@ -72,7 +72,7 @@ def get_new(obj)
       else
         found = find_in_space(obj.send(belongs), new_template.phases)
         obj = obj.send(:deep_copy)
-        obj.send("#{belongs}=", found)
+        obj.send(:"#{belongs}=", found)
       end
     end
     obj

app/controllers/plans_controller.rb

@@ -176,7 +176,7 @@ def show
                   .joins(:templates)
                   .where(templates: { published: true }).uniq.sort_by(&:name)
     # TODO: Seems strange to do this. Why are we just not using an `edit` route?
-    @editing = (!params[:editing].nil? && @plan.administerable_by?(current_user.id))
+    @editing = !params[:editing].nil? && @plan.administerable_by?(current_user.id)
 
     # Get all Guidance Groups applicable for the plan and group them by org
     @all_guidance_groups = @plan.guidance_group_options

app/helpers/conditions_helper.rb

@@ -107,11 +107,10 @@ def num_section_questions(plan, section, phase = nil)
   def sections_info(plan)
     return [] if plan.nil?
 
-    info = []
-    plan.sections.each do |section|
-      info.push(section_info(plan, section))
+    info = plan.sections.map do |section|
+      section_info(plan, section)
     end
-    info
+    info || []
   end
 
   def section_info(plan, section)
@@ -250,7 +249,7 @@ def conditions_to_param_form(conditions)
   def webhook_hash(conditions)
     web_hash = {}
     param_conditions = conditions_to_param_form(conditions)
-    param_conditions.each do |_title, params|
+    param_conditions.each_value do |params|
       web_hash.merge!(params[:number] => params[:webhook_data])
     end
     web_hash

app/models/application_record.rb

@@ -35,7 +35,7 @@ def safe_regexp_where_clause(column:)
 
   def sanitize_fields(*attrs)
     attrs.each do |attr|
-      send("#{attr}=", ActionController::Base.helpers.sanitize(send(attr)))
+      send(:"#{attr}=", ActionController::Base.helpers.sanitize(send(attr)))
     end
   end
 end

app/models/concerns/acts_as_sortable.rb

@@ -8,7 +8,7 @@ module ActsAsSortable
   class_methods do
     def update_numbers!(ids, parent:)
       # Ensure only records belonging to this parent are included.
-      ids = ids.map(&:to_i) & parent.public_send("#{model_name.singular}_ids")
+      ids = ids.map(&:to_i) & parent.public_send(:"#{model_name.singular}_ids")
       return if ids.empty?
 
       update_numbers_postgresql!(ids) if ApplicationRecord.postgres_db?

app/models/concerns/exportable_plan.rb

@@ -282,8 +282,8 @@ def record_plan_export(user, format)
       ep.format = format
       plan_settings = settings(:export)
 
-      Settings::Template::DEFAULT_SETTINGS.each do |key, _value|
-        ep.settings(:export).send("#{key}=", plan_settings.send(key))
+      Settings::Template::DEFAULT_SETTINGS.each_key do |key|
+        ep.settings(:export).send(:"#{key}=", plan_settings.send(key))
       end
     end
     exported_plan.save

app/models/question.rb

@@ -208,34 +208,33 @@ def update_conditions(param_conditions, old_to_new_opts, question_id_map)
     conditions.destroy_all
     return unless param_conditions.present?
 
-    param_conditions.each do |_key, value|
+    param_conditions.each_value do |value|
       save_condition(value, old_to_new_opts, question_id_map)
     end
   end
 
   # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+  # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
   def save_condition(value, opt_map, question_id_map)
     c = conditions.build
     c.action_type = value['action_type']
     c.number = value['number']
     # question options may have changed so rewrite them
     c.option_list = value['question_option']
     unless opt_map.blank?
-      new_question_options = []
-      c.option_list.each do |qopt|
-        new_question_options << opt_map[qopt]
+      new_question_options = c.option_list.map do |qopt|
+        opt_map[qopt]
       end
-      c.option_list = new_question_options
+      c.option_list = new_question_options || []
     end
 
     if value['action_type'] == 'remove'
       c.remove_data = value['remove_question_id']
       unless question_id_map.blank?
-        new_question_ids = []
-        c.remove_data.each do |qid|
-          new_question_ids << question_id_map[qid]
+        new_question_ids = c.remove_data.each do |qid|
+          question_id_map[qid]
         end
-        c.remove_data = new_question_ids
+        c.remove_data = new_question_ids || []
       end
     else
       c.webhook_data = {
@@ -247,6 +246,7 @@ def save_condition(value, opt_map, question_id_map)
     end
     c.save
   end
+  # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
   # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
 
   private

app/models/research_output.rb

@@ -76,14 +76,14 @@ class ResearchOutput < ApplicationRecord
 
   # Helper method to convert selected repository form params into Repository objects
   def repositories_attributes=(params)
-    params.each do |_i, repository_params|
+    params.each_value do |repository_params|
       repositories << Repository.find_by(id: repository_params[:id])
     end
   end
 
   # Helper method to convert selected metadata standard form params into MetadataStandard objects
   def metadata_standards_attributes=(params)
-    params.each do |_i, metadata_standard_params|
+    params.each_value do |metadata_standard_params|
       metadata_standards << MetadataStandard.find_by(id: metadata_standard_params[:id])
     end
   end