Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to add title when creating links in the CMS #2267

Open
eelzi-ONRR opened this issue Nov 7, 2022 · 7 comments
Open

Add ability to add title when creating links in the CMS #2267

eelzi-ONRR opened this issue Nov 7, 2022 · 7 comments
Assignees
Labels
Accessibility For all issues related to accessibility. CMS Involves the Directus CMS. Enhancement New feature or request P4: Low This doesn’t affect a large number of users, or we’re not sure exactly how much impact it has.

Comments

@eelzi-ONRR
Copy link
Contributor

eelzi-ONRR commented Nov 7, 2022

There's no way for someone working in the CMS to add a title tag or aria label to a link. We have pages that use buttons and hyperlink labels that are not unique, and making the labels unique is difficult due to the text that label would require. If we can use title tags and aria-labels to distinguish these buttons and labels, that would meet WCAG requirements.

Example: All the "Interactive Example" and "Download PDF" buttons and links on Valuation Examples.

@eelzi-ONRR eelzi-ONRR added Accessibility For all issues related to accessibility. CMS Involves the Directus CMS. Enhancement New feature or request labels Nov 7, 2022
@Maroyafaied Maroyafaied added the P3: Medium This doesn’t prevent the site from being used and can wait a bit before fixing. label Nov 16, 2022
@Maroyafaied Maroyafaied changed the title Add ability to add title & aria-label when creating links in the CMS Add ability to add title when creating links in the CMS Nov 25, 2022
@Maroyafaied
Copy link
Contributor

@R-mohansai I spoke with Erin and she explained that we wouldn't need the aria label if we can add titles to links and tables. I edited the issue and removed the aria label from it and assigned the issue for adding titles to tables (#2275) to this sprint as well.

@Maroyafaied
Copy link
Contributor

@eelzi-ONRR will review this as well as @cthomasONRR. I did a brief review and I believe it works properly now.

@R-mohansai
Copy link
Contributor

@Maroyafaied we have talked about it earlier in standup about this. Sure will look into that new issue.

@Maroyafaied
Copy link
Contributor

@cthomasONRR @eelzi-ONRR please ignore my comment, I added it to the wrong issue. This has not been implemented yet and not ready for review.

@R-mohansai
Copy link
Contributor

Added the new tooltip plugin for links to show hover with required info. Right not working perfectly but the feature is working can take some time to adjust the source code for it and also checking it in devtools by adjusting few things.

@Maroyafaied
Copy link
Contributor

@R-mohansai Should @cthomasONRR and @eelzi-ONRR test out the feature in the CMS now or wait for you to adjust the source code ? Will this be done by the end of this sprint?

@R-mohansai
Copy link
Contributor

R-mohansai commented Dec 15, 2022

@Maroyafaied still making few patches.This will done by the end of this sprint.

@Maroyafaied Maroyafaied added P4: Low This doesn’t affect a large number of users, or we’re not sure exactly how much impact it has. and removed P3: Medium This doesn’t prevent the site from being used and can wait a bit before fixing. labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility For all issues related to accessibility. CMS Involves the Directus CMS. Enhancement New feature or request P4: Low This doesn’t affect a large number of users, or we’re not sure exactly how much impact it has.
Projects
None yet
Development

No branches or pull requests

5 participants