Always display all files (even unchanged) for a submission.

Fixes #3115

Author: meisterT

webapp/templates/jury/partials/submission_diff.html.twig

@@ -18,31 +18,38 @@
         </tr>
     </table>
 {% endif %}
+{% set is_first_tab = true %}
+{# Mark the first tab that is shown as active. #}
+{% set extra_css_classes = "active" %}
 <ul class="nav nav-tabs source-tab-nav">
     {%- for filePair in oldFileStats.changedfiles %}
         <li class="nav-item">
-            <a class="nav-link {% if loop.first %}active{% endif %}" data-bs-toggle="tab"
+            <a class="nav-link {{ extra_css_classes }}" data-bs-toggle="tab"
                href="#diff-{{ filePair.1.submitfileid }}" role="tab">{{ filePair.0.filename }}</a>
         </li>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
     {%- for file in oldFileStats.unchangedfiles %}
         <li class="nav-item">
-            <a class="nav-link {% if loop.first %}active{% endif %}" data-bs-toggle="tab"
+            <a class="nav-link {{ extra_css_classes }}" data-bs-toggle="tab"
                href="#diff-{{ file.submitfileid }}" role="tab">{{ file.filename }}</a>
         </li>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
     {%- for file in oldFileStats.addedfiles %}
         <li class="nav-item">
-            <a class="nav-link {% if loop.first %}active{% endif %}" data-bs-toggle="tab"
+            <a class="nav-link {{ extra_css_classes }}" data-bs-toggle="tab"
                href="#diff-{{ file.submitfileid }}" role="tab">{{ file.filename }}</a>
         </li>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
 
 </ul>
+{# Mark the first pane that is shown as active. #}
+{% set extra_css_classes = "show active" %}
 <div class="tab-content source-tab">
     {%- for filePair in oldFileStats.changedfiles %}
-        <div class="tab-pane fade {% if loop.first %}show active{% endif %}" id="diff-{{ filePair.1.submitfileid }}"
-             role="tabpanel">
+        <div class="tab-pane fade {{ extra_css_classes }}" id="diff-{{ filePair.1.submitfileid }}" role="tabpanel">
             {% set diff_id = "diff" ~  filePair.1.submitfileid %}
             <div class="mb-1">
                 <a class="btn btn-secondary btn-sm"
@@ -65,10 +72,10 @@
             </div>
             {{ showDiff(diff_id, filePair.0, filePair.1) }}
         </div>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
     {%- for file in oldFileStats.unchangedfiles %}
-        <div class="tab-pane fade {% if loop.first %}show active{% endif %}" id="diff-{{ file.submitfileid }}"
-             role="tabpanel">
+        <div class="tab-pane fade {{ extra_css_classes }}" id="diff-{{ file.submitfileid }}" role="tabpanel">
             <div class="mb-1">
                 <a class="btn btn-secondary btn-sm"
                    href="{{ path('jury_submission_source', {submission: submission.submitid, fetch: file.rank}) }}">
@@ -81,11 +88,12 @@
                     </a>
                 {% endif %}
             </div>
+            {{ file.sourcecode | codeEditor(file.rank, submission.language.editorLanguage) }}
         </div>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
     {%- for file in oldFileStats.addedfiles %}
-        <div class="tab-pane fade {% if loop.first %}show active{% endif %}" id="diff-{{ file.submitfileid }}"
-             role="tabpanel">
+        <div class="tab-pane fade {{ extra_css_classes }}" id="diff-{{ file.submitfileid }}" role="tabpanel">
             <div class="mb-1">
                 <a class="btn btn-secondary btn-sm"
                    href="{{ path('jury_submission_source', {submission: submission.submitid, fetch: file.rank}) }}">
@@ -98,6 +106,8 @@
                     </a>
                 {% endif %}
             </div>
+            {{ file.sourcecode | codeEditor(file.rank, submission.language.editorLanguage) }}
         </div>
+        {% set extra_css_classes = "" %}
     {%- endfor %}
 </div>

webapp/templates/jury/submission_source.html.twig

@@ -41,7 +41,9 @@
         <p><a href="#origdiff">Go to diff to original submission</a></p>
     {%- endif %}
 
-    {% if not oldSubmission %}
+    {% if oldSubmission %}
+        {%- include 'jury/partials/submission_diff.html.twig' with {oldSubmission: oldSubmission, oldFiles: oldFiles, oldFileStats: oldFileStats} %}
+    {% else %}
         <ul class="nav nav-tabs source-tab-nav">
             {%- for file in files %}
                 <li class="nav-item">
@@ -74,10 +76,6 @@
         </div>
     {% endif %}
 
-    {%- if oldSubmission is not null %}
-        {%- include 'jury/partials/submission_diff.html.twig' with {oldSubmission: oldSubmission, oldFiles: oldFiles, oldFileStats: oldFileStats} %}
-    {%- endif %}
-
     {%- if originalSubmission is not null %}
         <h2 id="origdiff" class="mt-3">
             Diff to original submission
@@ -89,4 +87,4 @@
         {%- include 'jury/partials/submission_diff.html.twig' with {oldSubmission: originalSubmission, oldFiles: originalFiles, oldFileStats: originalFileStats} %}
     {%- endif %}
 
-{% endblock %}
+{% endblock %}