@@ -62,6 +62,7 @@ func (ic *importContext) emitInitScripts(initScripts []compute.InitScriptInfo) {
62
62
ic .emitWorkspaceFileOrRepo (is .Workspace .Destination )
63
63
}
64
64
if is .Volumes != nil {
65
+ // TODO: we should emit allow list for init scripts as well
65
66
ic .emitIfVolumeFile (is .Volumes .Destination )
66
67
}
67
68
}
@@ -413,6 +414,7 @@ func (ic *importContext) emitLibraries(libs []compute.Library) {
413
414
ic .emitIfWsfsFile (lib .Requirements )
414
415
// Files on UC Volumes
415
416
ic .emitIfVolumeFile (lib .Whl )
417
+ // TODO: we should emit UC allow list as well
416
418
ic .emitIfVolumeFile (lib .Jar )
417
419
ic .emitIfVolumeFile (lib .Requirements )
418
420
}
@@ -1160,7 +1162,7 @@ func listNotebooksAndWorkspaceFiles(ic *importContext) error {
1160
1162
allObjects := ic .getAllWorkspaceObjects (func (objects []workspace.ObjectStatus ) {
1161
1163
for _ , object := range objects {
1162
1164
if object .ObjectType == workspace .Directory {
1163
- if ! ic .incremental && object .Path != "/" && ic .isServiceEnabled ("directories" ) {
1165
+ if ! ic .incremental && object .Path != "/" && ic .isServiceInListing ("directories" ) {
1164
1166
objectsChannel <- object
1165
1167
}
1166
1168
} else {
@@ -1185,9 +1187,9 @@ func listNotebooksAndWorkspaceFiles(ic *importContext) error {
1185
1187
if ic .shouldSkipWorkspaceObject (object , updatedSinceMs ) {
1186
1188
continue
1187
1189
}
1188
- if object .ObjectType == workspace .Directory && ! ic .incremental && ic .isServiceEnabled ("directories" ) && object .Path != "/" {
1190
+ if object .ObjectType == workspace .Directory && ! ic .incremental && ic .isServiceInListing ("directories" ) && object .Path != "/" {
1189
1191
emitWorkpaceObject (ic , object )
1190
- } else if (object .ObjectType == workspace .Notebook || object .ObjectType == workspace .File ) && ic .isServiceEnabled ("notebooks" ) {
1192
+ } else if (object .ObjectType == workspace .Notebook || object .ObjectType == workspace .File ) && ic .isServiceInListing ("notebooks" ) {
1191
1193
emitWorkpaceObject (ic , object )
1192
1194
}
1193
1195
}
0 commit comments