Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_config_plot does not correctly deal with subscribers with both internal and external publishers #534

Open
eflumerf opened this issue Nov 5, 2024 · 0 comments · Fixed by #535
Assignees

Comments

@eflumerf
Copy link
Member

eflumerf commented Nov 5, 2024

Specifically noticed with the tcs_.* subscription in the MLT app. When plotting the whole example-configs/local-1x1-config configuration, tcs_.* is correctly shown going both from MLT to MLT and from hsi-to-tc-app to MLT. When plotting just the mlt, however (-r mlt), only the internal instance of tcs_.* is shown (the external inhttps://files.slack.com/files-pri/T03RN7KU3-F07V0PQSDNY/screenshot_2024-11-05_at_9.20.43___am.pngput from hsi-to-tc-app is missing).
Screenshot 2024-11-05 at 9 21 25 AM
Screenshot 2024-11-05 at 9 20 43 AM

@jcfreeman2 jcfreeman2 self-assigned this Nov 5, 2024
jcfreeman2 pushed a commit that referenced this issue Nov 5, 2024
The problem this commit deals with is basically, if you have a module
which subscribes on the network to a wildcarded message (say "msg_.*")
and another module in the same application which sends a version of
message that matches the wildcard (say "msg_A") out onto the network,
then how do you plot that?

Previously, when plotting, the logic in the plotter didn't care about
whether a message was sent onto the network. So it was drawing a
connection between the modules making it look as if they communicated
via a queue. With this commit, if we're plotting an application, a
message gets correctly represented as being sent out over the network,
and as being received from the network (with the usual "X" and "O" to
represent "region outside of this diagram").
@jcfreeman2 jcfreeman2 linked a pull request Nov 6, 2024 that will close this issue
jcfreeman2 added a commit that referenced this issue Nov 6, 2024
…_issue

JCF: Issue #534: deal with loopbacks in application plots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants