Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General refactoring of names for modules and configuration parameters #209

Open
MRiganSUSX opened this issue Apr 12, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@MRiganSUSX
Copy link
Contributor

MRiganSUSX commented Apr 12, 2023

Some names in the trigger/triggeralgs repositories are now old / inaccurate. A good example of this is the Horizontal Muon Activity Maker, which is configurable to not only trigger on muons but can also look for adjacencies/multiplicities etc. Additional refactoring should be considered for the schema options for particular plugin/module to make it obvious what module/plugin the option in question belongs to. Example of this is trigger_window_before_ticks which only changes the timing TCs - which is not obvious from the name. Another one would be trigger_rate_hz.

@MRiganSUSX MRiganSUSX added the enhancement New feature or request label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant