Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several FD genie fcls include missing fcls #39

Open
calcuttj opened this issue Oct 18, 2022 · 3 comments
Open

Several FD genie fcls include missing fcls #39

calcuttj opened this issue Oct 18, 2022 · 3 comments

Comments

@calcuttj
Copy link
Collaborator

The files below reference "prodgenie_nu_dune10kt_dphase.fcl" which is not found in any dunesw repo. However there is a seemingly similar file here

prodgenie_anu_dune10kt_workspace_4x2.fcl
prodgenie_anue_dune10kt_workspace_4x2.fcl
prodgenie_anutau_dune10kt_workspace_4x2.fcl
prodgenie_nu_dune10kt_workspace_4x2.fcl
prodgenie_nue_dune10kt_workspace_4x2.fcl
prodgenie_nutau_dune10kt_workspace_4x2.fcl

Found in https://github.com/DUNE/dunesw/blob/develop/fcl/dunefddp/gen/genie/

@calcuttj
Copy link
Collaborator Author

@absolution1 Any suggestions on what to do?

@absolution1
Copy link
Contributor

looks like I missed these when legacy'fying the FD fcls. To keep with the theme then all of the #includes would need updating to point to the legacy fcl, and the names of each of the workspace fcls would need 'legacy' appending.

How did this come up? Was someone attempting to use these? I figure that there should be very few people (no one?) using FD DP these days...

@calcuttj
Copy link
Collaborator Author

I'm working on cleaning up fcl includes such that no committed fcls include from a higher level dune repo. Eventually will turn this into a CI test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants