Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack Enable Status - Index Bug #355

Open
Ingunar opened this issue Sep 18, 2023 · 5 comments
Open

Hack Enable Status - Index Bug #355

Ingunar opened this issue Sep 18, 2023 · 5 comments

Comments

@Ingunar
Copy link
Collaborator

Ingunar commented Sep 18, 2023

Describe the bug
Changing the hack position or adding new hacks to the hacks_hash.ini will display the incorrect enabled or disabled status inside the System Menu Hacks section.

To Reproduce
If you add new hacks or move the hacks anywhere except the bottom of the hacks_hash.ini list, the Priiloader reads the hack status based on the Index position previously set. (Hacks not compatible with the system menu version count too)

Version
0.10.0

Expected behavior
The hacks enabled and disabled flags should match the previously set settings.

Additional context
This leads to full confusion about what is happening when saving new settings.

@DacoTaco
Copy link
Owner

euh, adding a hack should show all hacks disabled iirc?
or thats at least what the code should be doing :p

@Ingunar
Copy link
Collaborator Author

Ingunar commented Sep 19, 2023

Hmm trying to remember...

Does it check if you added/removed a hack with the same name?
Since we added and removed some min/max versions.

@Ingunar
Copy link
Collaborator Author

Ingunar commented Sep 19, 2023

hacks_hash (1)
hacks_hash (2)

From the Discord conversation:

I replaced the first one via FTP, and used WiiU Priiloader Forwarder, and checked the enabled/disabled flags

@DacoTaco
Copy link
Owner

if the amount of hacks stays the same it might be confused, but if the hacks amount changed they should all be disabled
just to clarify

@Ingunar
Copy link
Collaborator Author

Ingunar commented Sep 20, 2023

Okay, we can be sure about these two cases:

  • If you change the hack order
  • If you add a new one in the place of the existing one. (Name and code can be changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants