Weird dæmon compiler string transformation when compiler has linux in its name

[illwieckz]

The compilation command line does -DDAEMON_CXX_COMPILER_STRING=GCC_12.2.0:arm-linux-gnueabihf-g++ but the engine is printing this:

Unvanquished 0.55.2 Linux armhf (GCC_12.2.0:arm-1-gnueabihf-g++) Feb 12 2025

See how arm-linux-gnueabihf-g++ is transformed into arm-1-gnueabihf-g++.

I don't know what's happening there.

[illwieckz]

$ echo '' | arm-linux-gnueabihf-g++ -dM -E - | grep linux
#define __linux 1
#define __gnu_linux__ 1
#define linux 1
#define __linux__ 1

So, the compiler sets some linux definition to 1, but then, how can a definition be expanded within another definition?

[illwieckz]

Well, this is likely affecting any compiler having linux in its name:

Unvanquished 0.55.2 Linux arm64 (GCC_12.2.0:aarch64-1-gnu-g++) Feb 12 2025

Unvanquished 0.55.2 Linux amd64 (GCC_13.3.0:x86_64-1-gnu-g++) Feb 12 2025

[slipher]

As seen in #1497 it is risky to pass aribitrary data through command-line defines. Should generate a file like the GLSL embedded data

[illwieckz]

Fixed by:

• generate a DaemonBuildInfo.cpp file instead of using compiler definitions #1553