Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch-externals script to work with python3 #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hhyyrylainen
Copy link
Contributor

fixes #14

@illwieckz
Copy link
Member

Thanks! Maybe the shebang line can also be modified as #!/usr/bin/env python3?

No one is expected to run Python2 anymore. We probably don't use that script ourselves, that may explain why it was still expecting python2. 😀️

@hhyyrylainen
Copy link
Contributor Author

I didn't personally need that as Fedora has for a while now aliased python to refer to python3 automatically. So the line works as-is for me. But maybe some other distro might need that?

@illwieckz
Copy link
Member

Well, actually it still works with python2.7 (I just tried) so this is good as is.

@hhyyrylainen
Copy link
Contributor Author

That's great. I don't have any python2 installed so I couldn't test that, but good that the change is backwards compatible.

@slipher
Copy link
Member

slipher commented Jan 6, 2025

Yeah we never use that script. We changed the lss file to be a regular file instead of a submodule so that might need to be removed from DEPS for it to work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing python3 support
3 participants