Skip to content
This repository has been archived by the owner on Mar 11, 2023. It is now read-only.

Add ability to supply custom transport for akka http to support tunneling proxy #195

Open
apuckey opened this issue Feb 6, 2018 · 3 comments

Comments

@apuckey
Copy link

apuckey commented Feb 6, 2018

in this class: https://github.com/DanielaSfregola/twitter4s/blob/master/src/main/scala/com/danielasfregola/twitter4s/http/clients/CommonClient.scala#L21

I would like to be able to either:

supply a custom clientransport to use with Http().outgoingConnectionUsingTransport() instead of the other 2 it currently uses.

or the ability to override the Client trait to be able to add it to the twitterclients at runtime. I cant do this now as the OAuth2Provider classes are all private and wont allow this to happen.

disclaimer: I don't know scala that well yet :)

@DanielaSfregola
Copy link
Owner

HI @apuckey,
did you consider the existing proxy support? Have a look at https://github.com/DanielaSfregola/twitter4s#proxy-support

But yeah, I agree that allowing you to override the client transport would allow you to do a lot more

@apuckey
Copy link
Author

apuckey commented Feb 6, 2018

Thanks for getting back to me :)

I did see that you can change the domain but unfortunately thats not going to work in our system :) I ended up overriding some classes in the same namespace to make it work for now :)

@DanielaSfregola
Copy link
Owner

Thanks for clarifying!

We'll change our implementation to allow you to this!

In the meanwhile, PRs are always welcome ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants