Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer #6

Open
drikkes opened this issue Oct 20, 2021 · 2 comments
Open

footer #6

drikkes opened this issue Oct 20, 2021 · 2 comments

Comments

@drikkes
Copy link

drikkes commented Oct 20, 2021

Hi Danny,
I have your theme installed, and I like it. I have one question regarding the code here on GitHub (which seems the same as in the installed theme):
Why is there a footer only on the archive page, when the footer file itself is empty? And what would I have to do to get this footer on all pages & posts?

Thanks,
Hendrik

@DannyCooper
Copy link
Owner

DannyCooper commented Oct 20, 2021

Hi @drikkes,

When submitting a theme to WordPress.org there is a requirement to have a footer.php file (even if it isn't used).

The conditional statement to only show the footer on the archives is here:

https://github.com/DannyCooper/arke/blob/master/index.php#L41-L45

Removing line 41, 45 and 47 would make the footer show on all pages.

Let me know if I can help with anything else.

Thanks

@drikkes
Copy link
Author

drikkes commented Oct 25, 2021

Thanks for your answer, Danny.
I'm too stupid to delete lines of code, it seems.
When I erase that three lines from the index.php via the Theme Editor, instead of the footer I get non-working (because of a different permalink structure) "View All Posts" link at every end. Deleting line 46 as well does not do the trick.

And when you mentioned it: Is there a way to disable comments on pages, too, like it's possible on posts? My site does not need any comment option at all. Not only "comments are close" – simply "no comments".

Thanks,
Hendrik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants