diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/projects/workbench.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/projects/workbench.cy.ts index 92f20abc9d..380d8eb81d 100644 --- a/frontend/src/__tests__/cypress/cypress/tests/mocked/projects/workbench.cy.ts +++ b/frontend/src/__tests__/cypress/cypress/tests/mocked/projects/workbench.cy.ts @@ -511,7 +511,7 @@ describe('Workbench page', () => { notebookRow.findNotebookStatusPopover('Waiting for notebook to start...').should('exist'); }); - it('Edit workbench', () => { + it.only('Edit workbench', () => { initIntercepts({ notebookSizes: [ { diff --git a/frontend/src/pages/projects/screens/spawner/SpawnerFooter.tsx b/frontend/src/pages/projects/screens/spawner/SpawnerFooter.tsx index 2e37d8095b..7799b21dfb 100644 --- a/frontend/src/pages/projects/screens/spawner/SpawnerFooter.tsx +++ b/frontend/src/pages/projects/screens/spawner/SpawnerFooter.tsx @@ -13,6 +13,7 @@ import { assembleSecret, createNotebook, createSecret, + K8sStatusError, mergePatchUpdateNotebook, updateNotebook, } from '~/api'; @@ -56,7 +57,7 @@ const SpawnerFooter: React.FC = ({ dataConnection, canEnablePipelines, }) => { - const [errorMessage, setErrorMessage] = React.useState(''); + const [error, setError] = React.useState(); const { dashboardConfig: { @@ -123,17 +124,17 @@ const SpawnerFooter: React.FC = ({ refreshAllProjectData(); navigate(`/projects/${projectName}?section=${ProjectSectionID.WORKBENCHES}`); }; - const handleError = (e: Error) => { + const handleError = (e: K8sStatusError) => { fireFormTrackingEvent('Workbench Created', { outcome: TrackingOutcome.submit, success: false, error: e.message, }); - setErrorMessage(e.message || 'Error creating workbench'); + setError(e); setCreateInProgress(false); }; const handleStart = () => { - setErrorMessage(''); + setError(undefined); setCreateInProgress(true); }; @@ -281,7 +282,7 @@ const SpawnerFooter: React.FC = ({ return ( - {errorMessage && ( + {error && ( = ({ title="Error creating workbench" actionLinks={ // If this is a 409 conflict error - errorMessage.includes('the object has been modified') ? ( + error.statusObject.code === 409 ? ( <> @@ -309,7 +310,7 @@ const SpawnerFooter: React.FC = ({ ) : undefined } > - {errorMessage} + {error.message} )}