Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add extend options for marks #142

Open
1 task done
Darginec05 opened this issue May 8, 2024 · 3 comments
Open
1 task done

[FEATURE] Add extend options for marks #142

Darginec05 opened this issue May 8, 2024 · 3 comments

Comments

@Darginec05
Copy link
Owner

Is this a unique feature?

  • I have checked "open" AND "closed" issues and this is not a duplicate

Is your feature request related to a problem/unavailable functionality? Please describe.

Yes

Proposed Solution

Add .extend function to every mark

Screenshots

No response

Do you want to work on this issue?

Yes

If "yes" to the above, please explain how you would technically implement this (issue will not be assigned if this is skipped)

No response

@maZahaca
Copy link
Collaborator

Should marks also be extendible like plugins, to have a certain API to follow and you can add own marks?

@Darginec05
Copy link
Owner Author

@maZahaca the main point is add extend functionality for custom rendering of marks and adding some default props to each mark.
Ex: some devs want to extend props for highlight to add custom colors for text and backgroud.

@maZahaca
Copy link
Collaborator

Ok, so adding other marks sounds like another task. But can we define certain api protocol for it, as we have for plugins?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants