diff --git a/build.gradle b/build.gradle index 0be69c97b0..d833d48556 100644 --- a/build.gradle +++ b/build.gradle @@ -322,8 +322,8 @@ jacocoTestReport { } checkstyle { - configFile file("checkstyle/sun_checks.xml") - configFile file("checkstyle/println_checks.xml") + toolVersion "10.3.3" + configDirectory.set(rootProject.file("checkstyle/")) } opensearchplugin { diff --git a/checkstyle/sun_checks.xml b/checkstyle/checkstyle.xml similarity index 91% rename from checkstyle/sun_checks.xml rename to checkstyle/checkstyle.xml index d2818ef895..eaa44635e4 100644 --- a/checkstyle/sun_checks.xml +++ b/checkstyle/checkstyle.xml @@ -19,7 +19,7 @@ To suppress certain violations please review suppression filters. Finally, it is worth reading the documentation. --> - + + + + + + + @@ -188,6 +195,14 @@ + + + + + + + + @@ -215,5 +230,4 @@ - diff --git a/checkstyle/println_checks.xml b/checkstyle/println_checks.xml deleted file mode 100644 index 6fd2f7aff4..0000000000 --- a/checkstyle/println_checks.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - - - - - - - - - - - - - - - diff --git a/src/main/java/org/opensearch/security/dlic/rest/api/AbstractApiAction.java b/src/main/java/org/opensearch/security/dlic/rest/api/AbstractApiAction.java index 7cfb3854d9..6d3710871b 100644 --- a/src/main/java/org/opensearch/security/dlic/rest/api/AbstractApiAction.java +++ b/src/main/java/org/opensearch/security/dlic/rest/api/AbstractApiAction.java @@ -22,7 +22,6 @@ import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; import org.opensearch.ExceptionsHelper; -import org.opensearch.core.action.ActionListener; import org.opensearch.action.index.IndexRequest; import org.opensearch.action.index.IndexResponse; import org.opensearch.action.support.WriteRequest.RefreshPolicy; @@ -43,7 +42,6 @@ import org.opensearch.rest.RestChannel; import org.opensearch.rest.RestRequest; import org.opensearch.rest.RestRequest.Method; -import org.opensearch.core.rest.RestStatus; import org.opensearch.security.action.configupdate.ConfigUpdateAction; import org.opensearch.security.action.configupdate.ConfigUpdateRequest; import org.opensearch.security.action.configupdate.ConfigUpdateResponse; diff --git a/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java b/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java index 30e9c9baf1..640e52df6e 100644 --- a/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java +++ b/src/main/java/org/opensearch/security/dlic/rest/api/FlushCacheApiAction.java @@ -14,7 +14,6 @@ import com.google.common.collect.ImmutableList; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; -import org.opensearch.core.action.ActionListener; import org.opensearch.cluster.service.ClusterService; import org.opensearch.common.inject.Inject; import org.opensearch.core.action.ActionListener; diff --git a/src/main/java/org/opensearch/security/dlic/rest/api/MigrateApiAction.java b/src/main/java/org/opensearch/security/dlic/rest/api/MigrateApiAction.java index 22336f28d6..5402c0ac16 100644 --- a/src/main/java/org/opensearch/security/dlic/rest/api/MigrateApiAction.java +++ b/src/main/java/org/opensearch/security/dlic/rest/api/MigrateApiAction.java @@ -14,12 +14,10 @@ // CS-SUPPRESS-SINGLE: RegexpSingleline https://github.com/opensearch-project/OpenSearch/issues/3663 import com.google.common.collect.ImmutableList; - -import org.opensearch.LegacyESVersion; -import org.opensearch.Version; -import org.opensearch.core.action.ActionListener; import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.Logger; +import org.opensearch.LegacyESVersion; +import org.opensearch.Version; import org.opensearch.action.admin.indices.create.CreateIndexResponse; import org.opensearch.action.bulk.BulkRequestBuilder; import org.opensearch.action.bulk.BulkResponse; @@ -29,7 +27,6 @@ import org.opensearch.client.Client; import org.opensearch.cluster.metadata.IndexMetadata; import org.opensearch.cluster.service.ClusterService; -import org.opensearch.core.common.bytes.BytesReference; import org.opensearch.common.collect.Tuple; import org.opensearch.common.inject.Inject; import org.opensearch.common.settings.Settings;