Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less Lazy isAccessed and askingForAccount conditions #4

Open
madprogramer opened this issue Sep 3, 2021 · 1 comment
Open

Less Lazy isAccessed and askingForAccount conditions #4

madprogramer opened this issue Sep 3, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@madprogramer
Copy link
Member

The current isAccessed and askingForAccount conditions are very easy to dupe, perhaps also passing the URL and checking if the domain is drive.google.com might be a good idea.

docs.google.com etc. would need warnings, since they are not at risk of link rot and also because they would break any "drive.google.com" checking pattern.
@madprogramer madprogramer added enhancement New feature or request good first issue Good for newcomers labels Sep 3, 2021
@madprogramer
Copy link
Member Author

Partially fixed with #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@madprogramer