Skip to content

[DC-1790] Look into User Issue "not authorized" ingest failure despite correct permissions #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

[DC-1790] Look into User Issue "not authorized" ingest failure despite correct permissions #2037

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a53aa86
add error message and unit tests
raejohanek Oct 17, 2025
5582bcd
finish adding unit tests
raejohanek Oct 20, 2025
23c5518
add if available bc project id may be null
raejohanek Oct 20, 2025
a284ca3
rm unnecessary log, BlobAccessNotAuthorizedException will show this i…
raejohanek Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/main/java/bio/terra/service/filedata/google/gcs/GcsPdao.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,22 +384,28 @@ public void validateUserCanRead(
for (String bucket : buckets) {
List<Boolean> permissions = List.of();
try {
permissions =
storageAsPet.testIamPermissions(
bucket, List.of(GCS_SOURCE_BUCKET_REQUIRED_PERMISSION), options);
logger.info(
"Testing Iam permission: Bucket {}, Pet Service Account {}, Permission Requested {}, Accessible {}",
"Testing Iam permission: Bucket {}, Pet Service Account {}, Permission Requested {}, Dataset's Project ID if available {}",
bucket,
token.getEmail(),
List.of(GCS_SOURCE_BUCKET_REQUIRED_PERMISSION),
permissions);
cloudEncapsulationId);
permissions =
storageAsPet.testIamPermissions(
bucket, List.of(GCS_SOURCE_BUCKET_REQUIRED_PERMISSION), options);
logger.info("Permissions test result: {}", permissions);
Copy link
Contributor

@samanehsan samanehsan Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to log the result of every bucket permissions check, since the important/useful bit is whether it fails. What do you think?

} catch (StorageException e) {
// This is a potential failure mode for permissions checking: not being able to make the
// permissions check call at all
logger.warn(e.toString());
if (e.getCode() != HttpStatus.SC_FORBIDDEN) {
throw e;
}
throw new StorageException(
e.getCode(),
String.format(
"Could not test permissions. Bucket %s, Pet Service Account %s, Permission Requested %s, Dataset's Project ID if available %s. %s",
bucket,
token.getEmail(),
GCS_SOURCE_BUCKET_REQUIRED_PERMISSION,
cloudEncapsulationId,
e));
}

if (!permissions.equals(List.of(true))) {
Expand Down
Loading