From aef3c52c031a556b3d8938c36bc8991b88787c9d Mon Sep 17 00:00:00 2001 From: Peter Rifel Date: Fri, 4 Oct 2024 10:50:20 -0500 Subject: [PATCH] Update release-1.29-dd to 1.29.6 (#1) * Handle error while registering/deregistering target during load balancer update * Release v1.29.6 --------- Co-authored-by: Jay Deokar Co-authored-by: Kubernetes Prow Robot <20407524+k8s-ci-robot@users.noreply.github.com> --- pkg/providers/v1/aws.go | 3 ++- version.txt | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/providers/v1/aws.go b/pkg/providers/v1/aws.go index b1324cb01b..f3876b679c 100644 --- a/pkg/providers/v1/aws.go +++ b/pkg/providers/v1/aws.go @@ -4492,7 +4492,8 @@ func (c *Cloud) UpdateLoadBalancer(ctx context.Context, clusterName string, serv err = c.ensureLoadBalancerInstances(aws.StringValue(lb.LoadBalancerName), lb.Instances, instances) if err != nil { - return nil + klog.Warningf("Error registering/deregistering instances with the load balancer: %q", err) + return err } err = c.updateInstanceSecurityGroupsForLoadBalancer(lb, instances, service.Annotations) diff --git a/version.txt b/version.txt index 546ac9bcd6..f5519b88ac 100644 --- a/version.txt +++ b/version.txt @@ -1 +1 @@ -1.29.5 +1.29.6