Skip to content

Commit 7fd6e7d

Browse files
JulienBalestrahush-hush
authored andcommitted
pause-container: update the list of the pause containers (#3670)
1 parent d54507b commit 7fd6e7d

File tree

2 files changed

+25
-3
lines changed

2 files changed

+25
-3
lines changed

tests/core/test_dockerutil.py

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010

1111
class TestDockerUtil(unittest.TestCase):
12-
1312
def test_parse_subsystem(self):
1413
lines = [
1514
# (line, expected_result)
@@ -138,7 +137,6 @@ def test_extract_container_tags(self):
138137
for test in labeled_test_data:
139138
self.assertEqual(test[2], DockerUtil().extract_container_tags(test[0], test[1]))
140139

141-
142140
def test_docker_host_metadata_ok(self):
143141
mock_version = mock.MagicMock(name='version', return_value={'Version': '1.13.1'})
144142
du = DockerUtil()
@@ -167,3 +165,22 @@ def test_docker_host_metadata_swarm_ok(self):
167165

168166
self.assertEqual({'docker_version': '1.13.1', 'docker_swarm': 'active'}, DockerUtil().get_host_metadata())
169167
mock_version.assert_called_once()
168+
169+
def test_docker_are_tags_filtered(self):
170+
with mock.patch.object(DockerUtil, 'is_k8s', side_effect=lambda: True):
171+
DockerUtil._drop()
172+
du = DockerUtil()
173+
174+
self.assertTrue(du.is_k8s())
175+
pause_containers = [
176+
"docker_image:gcr.io/google_containers/pause-amd64:0.3.0",
177+
"docker_image:k8s.gcr.io/pause-amd64:latest",
178+
"image_name:openshift/origin-pod",
179+
"image_name:kubernetes/pause",
180+
]
181+
for image in pause_containers:
182+
self.assertTrue(du.are_tags_filtered([image]))
183+
184+
self.assertTrue(pause_containers)
185+
self.assertFalse(du.are_tags_filtered(["docker_image:quay.io/coreos/etcd:latest"]))
186+
self.assertFalse(du.are_tags_filtered(["image_name:redis"]))

utils/dockerutil.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,12 @@ class CGroupException(Exception):
4646
DEFAULT_RETRY_INTERVAL = 20 # seconds
4747

4848
# only used if no exclude rule was defined
49-
DEFAULT_CONTAINER_EXCLUDE = ["docker_image:gcr.io/google_containers/pause.*", "image_name:openshift/origin-pod"]
49+
DEFAULT_CONTAINER_EXCLUDE = [
50+
"docker_image:gcr.io/google_containers/pause.*",
51+
"docker_image:k8s.gcr.io/pause.*",
52+
"image_name:openshift/origin-pod",
53+
"image_name:kubernetes/pause"
54+
]
5055

5156
log = logging.getLogger(__name__)
5257

0 commit comments

Comments
 (0)