Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kotlin Multiplatform and Ktor #1773

Open
ThomasRichtsfeld opened this issue Dec 19, 2023 · 5 comments
Open

Support for Kotlin Multiplatform and Ktor #1773

ThomasRichtsfeld opened this issue Dec 19, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@ThomasRichtsfeld
Copy link

Are you requesting automatic instrumentation for a framework or library? Please describe.

  • Framework or library name : KMP, Ktor
  • Library type: KMP library
  • Library version: ktor version. 2.3.4

Is your feature request related to a problem? Please describe.
We are currently using Ktor in one of our KMP modules. None of the network calls are reported in Datadog. All the other network calls that are done with retrofit are reported.

Describe the solution you'd like
If Datadog is installed in the App module it should automatically trace the network requests that are done with the Ktor HttpClient

Describe alternatives you've considered
We didn't find an alternative solution

@ThomasRichtsfeld ThomasRichtsfeld added the enhancement New feature or request label Dec 19, 2023
@jonathanmos
Copy link
Contributor

hi @ThomasRichtsfeld, thanks for this feature request. We don't currently have plans to support KMP. Regarding Ktor we will discuss and see whether it is possible.

@ThomasRichtsfeld
Copy link
Author

From our POV we don't need support for KMP, as long as tracing works for Ktor out of the box.

Thanks for the update @jonathanmos

@tassilo-posegga
Copy link

tassilo-posegga commented Mar 5, 2024

Any updates on this ussue? It looks like we are not the only ones with this need: https://www.reddit.com/r/ktor/comments/10584a3/ktor_client_tracing_and_monitoring_for_a_kotlin/

@ThomasRichtsfeld one solution could be using OkHttp instead, which starts KMP support with version 5

@0xnm
Copy link
Contributor

0xnm commented Mar 5, 2024

Hello @tassilo-posegga! There is no update on this topic so far, it is not at the top of our list, but if we see that this feature is highly requested this will definitely change its priority for us.

@christer-hansen
Copy link

Ktor is growing bigger and bigger, it would be great to have support for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants