RUM-12441 Graphql errors #2552
Open
RUM-12441 Graphql errors #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barboraplasovska
force-pushed
the
bplasovska/RUM-12441/graphql-errors
branch
6 times, most recently
from
2917f4b to
85a1acc
Compare
This comment has been minimized.
This comment has been minimized.
barboraplasovska
force-pushed
the
bplasovska/RUM-12441/graphql-errors
branch
5 times, most recently
from
35f7626 to
3fc640f
Compare
barboraplasovska
commented
Nov 3, 2025
Comment on lines
+12
to
+25
| // Extension to make Path conform to Equatable for testing | ||
| extension RUMResourceEvent.Resource.Graphql.Errors.Path: Equatable { | ||
| public static func == (lhs: RUMResourceEvent.Resource.Graphql.Errors.Path, rhs: RUMResourceEvent.Resource.Graphql.Errors.Path) -> Bool { | ||
| switch (lhs, rhs) { | ||
| case (.string(let lhsValue), .string(let rhsValue)): | ||
| return lhsValue == rhsValue | ||
| case (.integer(let lhsValue), .integer(let rhsValue)): | ||
| return lhsValue == rhsValue | ||
| default: | ||
| return false | ||
| } | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I added this extension to be able to do XCTAssertEqual on a Path. Not sure if there is a better way to make this testable.
git-thuerk-done
previously approved these changes
Nov 3, 2025
maxep
requested changes
Nov 6, 2025
|
|
||
| init(from decoder: Decoder) throws { | ||
| let container = try decoder.container(keyedBy: CodingKeys.self) | ||
| hasErrors = container.contains(.errors) |
DatadogRUM/Sources/Instrumentation/Resources/URLSessionRUMResourcesHandler.swift
Outdated
Show resolved
Hide resolved
mariedm
previously approved these changes
Nov 12, 2025
barboraplasovska
force-pushed
the
bplasovska/RUM-12441/graphql-errors
branch
from
763d032 to
3ef2031
Compare
Contributor
Author
|
Forced pushed to resolve merge conflicts with the develop branch. |
rtrieu
approved these changes
Nov 12, 2025
rtrieu
previously approved these changes
Nov 12, 2025
maxep
approved these changes
Nov 12, 2025
git-thuerk-done
approved these changes
Nov 12, 2025
Contributor
|
Hi @barboraplasovska is this ready to merge? |
rtrieu
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
GraphQL APIs follow a different error model than REST APIs, they return HTTP
200 OKstatus codes even when operations fail with errors included in the response body under anerrorskey. Without parsing the response body, these errors would go unnoticed in RUM monitoring.This PR adds support for automatically detecting, parsing, and reporting GraphQL errors in RUM resource events. When a GraphQL request completes with errors in the response, the SDK now captures and includes them in the resource event.
How?
When a request completes with a JSON response, we check for the presence of an
errorskey. If found, the response body is passed along to the resource scope where it's decoded according to the GraphQL spec and populated into the resource event'sgraphql.errorsarray andgraphql.errorCountfields. (cc PR onrum_events_format).Review checklist
make api-surface)