From 5c5c4df69dcd38e0f428ba8c22355fc79044ffc5 Mon Sep 17 00:00:00 2001 From: liashenko Date: Tue, 9 Jul 2024 11:23:07 +0200 Subject: [PATCH] Do not check git commit details for github --- .../integrations/gotesting/testing_test.go | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/internal/civisibility/integrations/gotesting/testing_test.go b/internal/civisibility/integrations/gotesting/testing_test.go index a2b7ac1f1b..e45e62d15d 100644 --- a/internal/civisibility/integrations/gotesting/testing_test.go +++ b/internal/civisibility/integrations/gotesting/testing_test.go @@ -329,12 +329,15 @@ func assertCommon(assert *assert.Assertions, span mocktracer.Span) { assert.Contains(spanTags, constants.RuntimeName) assert.Contains(spanTags, constants.GitRepositoryURL) assert.Contains(spanTags, constants.GitCommitSHA) - assert.Contains(spanTags, constants.GitCommitMessage) - assert.Contains(spanTags, constants.GitCommitAuthorEmail) - assert.Contains(spanTags, constants.GitCommitAuthorDate) - assert.Contains(spanTags, constants.GitCommitCommitterEmail) - assert.Contains(spanTags, constants.GitCommitCommitterDate) - assert.Contains(spanTags, constants.GitCommitCommitterName) + // GitHub CI does not provide commit details + if spanTags[constants.CIProviderName] != "github" { + assert.Contains(spanTags, constants.GitCommitMessage) + assert.Contains(spanTags, constants.GitCommitAuthorEmail) + assert.Contains(spanTags, constants.GitCommitAuthorDate) + assert.Contains(spanTags, constants.GitCommitCommitterEmail) + assert.Contains(spanTags, constants.GitCommitCommitterDate) + assert.Contains(spanTags, constants.GitCommitCommitterName) + } assert.Contains(spanTags, constants.CIWorkspacePath) }