-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: block until span send seccessful #2505
Comments
@zdyj3170101136 Please see the
|
my meaning is, the client would push span to channel and if channel full it would dropped. so if one program have high qps, it's span per second would too high, so a huge percent of span would dropped. i think the client should promise each span should be sent to agent. |
@zdyj3170101136 We recommend to use sampling too in this kind of situations. Trying to guarantee that every span is sent to the agent could lead to high memory consumption if any back pressure is generated by the agent. For further discussion, we also recommend to get in touch with support. They'll help you to identify the root cause of the issue. |
here is my company solution: let every agent sent full trace, and sample at collector. so that we will get useful trace: like p99, error and so on. |
@zdyj3170101136 We recommend in this case to contact support, to understand better your use case and be able to help. Please refer to this GitHub issue in the support ticket. |
for now, the client sent trace use an unblocking channel.
if the channel push, the span would dropped.
this would cause if a trace is too large, have too much span, then it would loss some span in trace, unavoidable.
The text was updated successfully, but these errors were encountered: