You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upgrading from github.com/google/pprof v0.0.0-20231229205709-960ae82b1e42 to github.com/google/pprof v0.0.0-20240117000934-35fc243c5815 causes a build error in dd-trace-go.v1.
Version of dd-trace-go
gopkg.in/DataDog/dd-trace-go.v1 v1.59.0
Describe what happened:
After upgrading, simply running go test results in this error output:
Upgrading from
github.com/google/pprof v0.0.0-20231229205709-960ae82b1e42
togithub.com/google/pprof v0.0.0-20240117000934-35fc243c5815
causes a build error in dd-trace-go.v1.Version of dd-trace-go
gopkg.in/DataDog/dd-trace-go.v1 v1.59.0
Describe what happened:
After upgrading, simply running
go test
results in this error output:gopkg.in/DataDog/dd-trace-go.v1/profiler/internal/pprofutils
../../../go/pkg/mod/gopkg.in/!data!dog/[email protected]/profiler/internal/pprofutils/protobuf.go:36:57: not enough arguments in call to protobuf.Aggregate
have (bool, bool, bool, bool, bool)
want (bool, bool, bool, bool, bool, bool)
Google updated pprof today, and released a breaking change to an exported function:
https://github.com/google/pprof/pull/818/files#diff-213323d4ae136c7b733df56c9658661e0b6b6aa64f60adc7ca95b9e3a04ec367R440
Describe what you expected:
The package to continue working as normal.
Steps to reproduce the issue:
Reference the latest version of
github.com/google/pprof
andgopkg.in/DataDog/dd-trace-go.v1
Additional environment details (Version of Go, Operating System, etc.):
Mac, Go 1.21.5
The text was updated successfully, but these errors were encountered: