Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of github.com/google/pprof breaks dd-trace-go #2519

Closed
ztkent opened this issue Jan 17, 2024 · 1 comment · Fixed by #2515
Closed

Latest version of github.com/google/pprof breaks dd-trace-go #2519

ztkent opened this issue Jan 17, 2024 · 1 comment · Fixed by #2515
Labels
bug unintended behavior that has to be fixed profiler

Comments

@ztkent
Copy link

ztkent commented Jan 17, 2024

Upgrading from github.com/google/pprof v0.0.0-20231229205709-960ae82b1e42 to github.com/google/pprof v0.0.0-20240117000934-35fc243c5815 causes a build error in dd-trace-go.v1.

Version of dd-trace-go
gopkg.in/DataDog/dd-trace-go.v1 v1.59.0

Describe what happened:
After upgrading, simply running go test results in this error output:

gopkg.in/DataDog/dd-trace-go.v1/profiler/internal/pprofutils

../../../go/pkg/mod/gopkg.in/!data!dog/[email protected]/profiler/internal/pprofutils/protobuf.go:36:57: not enough arguments in call to protobuf.Aggregate
have (bool, bool, bool, bool, bool)
want (bool, bool, bool, bool, bool, bool)

Google updated pprof today, and released a breaking change to an exported function:
https://github.com/google/pprof/pull/818/files#diff-213323d4ae136c7b733df56c9658661e0b6b6aa64f60adc7ca95b9e3a04ec367R440

Describe what you expected:
The package to continue working as normal.

Steps to reproduce the issue:
Reference the latest version of github.com/google/pprof and gopkg.in/DataDog/dd-trace-go.v1

Additional environment details (Version of Go, Operating System, etc.):
Mac, Go 1.21.5

@ztkent ztkent added the bug unintended behavior that has to be fixed label Jan 17, 2024
@github-actions github-actions bot added apm:ecosystem contrib/* related feature requests or bugs needs-triage New issues that have not yet been triaged labels Jan 17, 2024
@nsrip-dd
Copy link
Contributor

Thanks! #2515 will fix this

@nsrip-dd nsrip-dd added profiler and removed apm:ecosystem contrib/* related feature requests or bugs needs-triage New issues that have not yet been triaged labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behavior that has to be fixed profiler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants