You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many of the other frameworks supported in contrib offer something along the lines as what the echo dd-trace-go package offers here, where a user can provide a function to determine whether or not a given trace should be considered an error (i.e a user wants to report 400s as errors or want to not report a single specific code for some reason)
I suggest we support something similar here and update this check to use the new configured function instead. This way, explicit usage of TraceAndServe(...) can supply a function for it's ServeConfig (my use case), and the contrib/net/http package's dependence upon this function can also provide a functional option to it's ServeMux's configuration that can simply pass right through to this TraceAndServe function.
LMK what you think! Thanks
The text was updated successfully, but these errors were encountered:
Many of the other frameworks supported in
contrib
offer something along the lines as what the echo dd-trace-go package offers here, where a user can provide a function to determine whether or not a given trace should be considered an error (i.e a user wants to report 400s as errors or want to not report a single specific code for some reason)I suggest we support something similar here and update this check to use the new configured function instead. This way, explicit usage of
TraceAndServe(...)
can supply a function for it'sServeConfig
(my use case), and thecontrib/net/http
package's dependence upon this function can also provide a functional option to it's ServeMux's configuration that can simply pass right through to thisTraceAndServe
function.LMK what you think! Thanks
The text was updated successfully, but these errors were encountered: