fix: SpotBugs needs 6.4.2 to run after JDK11, relax forbiddenApis on internal-api

Also this forces JDK 11 to be the minimum.

Author: bric3

build.gradle.kts

@@ -5,7 +5,8 @@ plugins {
   id("datadog.dependency-locking")
 
   id("com.diffplug.spotless") version "6.13.0"
-  id("com.github.spotbugs") version "5.0.14"
+  // id("com.github.spotbugs") version "5.0.14"
+  id("com.github.spotbugs") version "6.4.2"
   id("de.thetaphi.forbiddenapis") version "3.8"
 
   id("tracer-version")

gradle/forbiddenapis.gradle

@@ -33,10 +33,8 @@ forbiddenApis {
 }
 
 // disable forbiddenApis for all test tasks
-afterEvaluate {
-  tasks.matching({it.name.startsWith('forbiddenApis') && it.name.endsWith('Test')}).configureEach {
-    it.enabled = false
-  }
+tasks.matching { it.name.startsWith('forbiddenApis') && it.name.endsWith('Test') }.configureEach {
+  it.enabled = false
 }
 
 dependencies {

gradle/spotbugs.gradle

@@ -6,44 +6,55 @@ spotbugs {
 }
 
 // configure spotbugs for Main tasks and disable it for all other
-afterEvaluate {
-  tasks.withType(spotbugsMain.class).configureEach {
-    def name = it.name
-    if (name.endsWith("Main") || name.endsWith("Main_java11")) {
-      it.ignoreFailures = false
-      // detector documentation is in the following link:
-      // https://spotbugs-in-kengo-toda.readthedocs.io/en/lqc-list-detectors/detectors.html
-      it.omitVisitors = [
-        'DefaultEncodingDetector',
-        'DoInsideDoPrivileged',
-        'DontUseEnum',
-        'DroppedException',
-        'FindDeadLocalStores',
-        'FindHEmismatch',
-        'FindNullDeref',
-        'FindReturnRef',
-        'FindRunInvocations',
-        'FindUselessControlFlow',
-        'InitializationChain',
-        'LazyInit',
-        'LoadOfKnownNullValue',
-        'LostLoggerDueToWeakReference',
-        'MethodReturnCheck',
-        'MutableStaticFields',
-        'Naming',
-        'RuntimeExceptionCapture',
-        'SerializableIdiom',
-        'UnreadFields',
-      ]
-      it.reports {
-        html {
-          enabled = true
-          destination = file("$buildDir/reports/spotbugs/${name}.html")
-          stylesheet = 'fancy-hist.xsl'
-        }
-      }
-    } else {
-      it.enabled = false
+// Can't use the class here due to being different class
+tasks.matching { it.name.startsWith('spotbugs') }.configureEach {
+  it.launcher = javaToolchains.launcherFor {
+    it.languageVersion = JavaLanguageVersion.current()
+  }
+
+  def launcher = it.launcher
+  doFirst {
+    println(launcher.get().executablePath)
+  }
+
+  def name = it.name
+  if (!(name.endsWith("Main") || name.endsWith("Main_java11"))) {
+    it.enabled = false
+    return
+  }
+
+  it.showProgress = true
+  it.ignoreFailures = false
+  // detector documentation is in the following link:
+  // https://spotbugs-in-kengo-toda.readthedocs.io/en/lqc-list-detectors/detectors.html
+  it.omitVisitors = [
+    'ConstructorThrow',
+    'DefaultEncodingDetector',
+    'DoInsideDoPrivileged',
+    'DontUseEnum',
+    'DroppedException',
+    'FindDeadLocalStores',
+    'FindHEmismatch',
+    'FindNullDeref',
+    'FindReturnRef',
+    'FindRunInvocations',
+    'FindUselessControlFlow',
+    'InitializationChain',
+    'LazyInit',
+    'LoadOfKnownNullValue',
+    'LostLoggerDueToWeakReference',
+    'MethodReturnCheck',
+    'MutableStaticFields',
+    'Naming',
+    'RuntimeExceptionCapture',
+    'SerializableIdiom',
+    'UnreadFields',
+  ]
+  it.reports {
+    html {
+      required = true
+      destination(file("$buildDir/reports/spotbugs/${name}.html"))
+      stylesheet = 'fancy-hist.xsl'
     }
   }
 }

internal-api/build.gradle.kts

@@ -1,3 +1,4 @@
+import de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis
 import groovy.lang.Closure
 
 plugins {
@@ -22,6 +23,11 @@ fun AbstractCompile.configureCompiler(javaVersionInteger: Int, compatibilityVers
   (project.extra["configureCompiler"] as Closure<*>).call(this, javaVersionInteger, compatibilityVersion, unsetReleaseFlagReason)
 }
 
+tasks.named<CheckForbiddenApis>("forbiddenApisMain") {
+  // sun.* are accessible in JDK8, but maybe not accessible when this task is running
+  failOnMissingClasses = false
+}
+
 val minimumBranchCoverage by extra(0.7)
 val minimumInstructionCoverage by extra(0.8)