From 841d9337a680d1b2e19dbe616cc1873ca1d0419d Mon Sep 17 00:00:00 2001 From: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com> Date: Mon, 17 Jun 2024 15:11:30 +0200 Subject: [PATCH] Ignore exception when trying to remove Git data upload shutdown hook during JVM shutdown (#7204) --- .../trace/civisibility/git/tree/GitDataUploaderImpl.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/GitDataUploaderImpl.java b/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/GitDataUploaderImpl.java index c79741aa8e4..483285802a5 100644 --- a/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/GitDataUploaderImpl.java +++ b/dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/GitDataUploaderImpl.java @@ -167,7 +167,15 @@ private void uploadGitData() { LOGGER.error("Failed to upload git tree data for remote {}", remoteName, e); callback.completeExceptionally(e); } finally { + removeShutdownHook(); + } + } + + private void removeShutdownHook() { + try { Runtime.getRuntime().removeShutdownHook(uploadFinishedShutdownHook); + } catch (IllegalStateException e) { + // JVM is being shutdown } }