Datadog Trace Span Issue with Apache HttpClient5

[abagavat]

We observed an issue with the Datadog trace span for outbound http requests using Apache HttpClient5. This span is missing some of the url details info, mainly the host information. Upon closer inspection we were able to identify the specific aspect advice that was applied for this interaction.

dd-trace-java/dd-java-agent/instrumentation/apache-httpclient-5/src/main/java/datadog/trace/instrumentation/apachehttpclient5/ApacheHttpClientInstrumentation.java

Line 87 in 1496a6c

transformer.applyAdvice(

In our specific case, the first parameter (host) in the method call is null. As per Apache HttpClient5 documentation this argument is allowed to be null. When it's null the implementation should derive the host information from the request itself.

https://hc.apache.org/httpcomponents-client-5.2.x/current/httpclient5/apidocs/org/apache/hc/client5/http/classic/HttpClient.html#executeOpen-org.apache.hc.core5.http.HttpHost-org.apache.hc.core5.http.ClassicHttpRequest-org.apache.hc.core5.http.protocol.HttpContext-

More specifically the below wrapper class which wraps HttpClient's BasicClassicHttpRequest should handle a null host value. The fix can either be in the constructor or by overriding the getUri method and fetch the uri from the actual request.

dd-trace-java/dd-java-agent/instrumentation/apache-httpclient-5/src/main/java/datadog/trace/instrumentation/apachehttpclient5/HostAndRequestAsHttpUriRequest.java

Line 13 in 0327c4d

public HostAndRequestAsHttpUriRequest(final HttpHost httpHost, final HttpRequest httpRequest) {

The impact of this issue (missing host info) is that, some of the widgets in the APM dashboard such as the dependency map are not showing the correct data.

[abagavat]

Potential fix - #7276

[mcculls]

#7276 has been merged and will be available in the next release, v1.38.0