Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change redacted values in snapshot & log templates #6103

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Change redacted values in snapshot & log templates #6103

merged 1 commit into from
Nov 1, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 26, 2023 •
edited
Loading

What Does This Do

in log template use {redacted} instead of the evaluation error message

for snapshot indicated the by which part it was redacted:

  • redactedIdent for keyword redaction
  • redactedType for type redaction

Motivation

Additional Notes

Jira ticket: DEBUG-1897

@jpbempel
Change redacted values in snapshot & log templates
339e24b 
in log template use {redacted} instead of the evaluation error message
for snapshot indicated the by which part it was redacted:
- redactedIdent for keyword redaction
- redactedType for type redaction
@jpbempel jpbempel requested a review from a team as a code owner October 26, 2023 08:47
@jpbempel jpbempel requested review from cimi and removed request for a team October 26, 2023 08:47
@pr-commenter
Copy link

pr-commenter bot commented Oct 26, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~9ae368faea 1.22.0-SNAPSHOT~339e24bd87
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 53 cases.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:petclinic:iast:IAST better
[-4.985ms; -0.493ms] or [-28.910%; -2.860%]		 14.503ms 17.242ms
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027798
Total [baseline] (9.263 s) : 0, 9262645
Agent [candidate] (1.035 s) : 0, 1034761
Total [candidate] (9.366 s) : 0, 9366013
section appsec
Agent [baseline] (1.109 s) : 0, 1109422
Total [baseline] (9.292 s) : 0, 9291766
Agent [candidate] (1.109 s) : 0, 1109483
Total [candidate] (9.343 s) : 0, 9343380
section iast
Agent [baseline] (1.147 s) : 0, 1147409
Total [baseline] (9.394 s) : 0, 9393651
Agent [candidate] (1.154 s) : 0, 1154443
Total [candidate] (9.44 s) : 0, 9440089
section profiling
Agent [baseline] (1.195 s) : 0, 1195437
Total [baseline] (9.512 s) : 0, 9512285
Agent [candidate] (1.199 s) : 0, 1198773
Total [candidate] (9.569 s) : 0, 9569362
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.028 s -
Agent appsec 1.109 s 81.624 ms (7.9%)
Agent iast 1.147 s 119.612 ms (11.6%)
Agent profiling 1.195 s 167.639 ms (16.3%)
Total tracing 9.263 s -
Total appsec 9.292 s 29.121 ms (0.3%)
Total iast 9.394 s 131.006 ms (1.4%)
Total profiling 9.512 s 249.64 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent appsec 1.109 s 74.722 ms (7.2%)
Agent iast 1.154 s 119.682 ms (11.6%)
Agent profiling 1.199 s 164.011 ms (15.9%)
Total tracing 9.366 s -
Total appsec 9.343 s -22.633 ms (-0.2%)
Total iast 9.44 s 74.076 ms (0.8%)
Total profiling 9.569 s 203.349 ms (2.2%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (641.968 ms) : 0, 641968
BytebuddyAgent [candidate] (647.354 ms) : 0, 647354
GlobalTracer [baseline] (295.169 ms) : 0, 295169
GlobalTracer [candidate] (296.335 ms) : 0, 296335
AppSec [baseline] (49.203 ms) : 0, 49203
AppSec [candidate] (49.286 ms) : 0, 49286
Remote Config [baseline] (689.774 µs) : 0, 690
Remote Config [candidate] (698.048 µs) : 0, 698
Telemetry [baseline] (6.104 ms) : 0, 6104
Telemetry [candidate] (6.134 ms) : 0, 6134
section appsec
BytebuddyAgent [baseline] (638.685 ms) : 0, 638685
BytebuddyAgent [candidate] (638.465 ms) : 0, 638465
GlobalTracer [baseline] (292.247 ms) : 0, 292247
GlobalTracer [candidate] (292.686 ms) : 0, 292686
AppSec [baseline] (137.765 ms) : 0, 137765
AppSec [candidate] (137.693 ms) : 0, 137693
Remote Config [baseline] (644.154 µs) : 0, 644
Remote Config [candidate] (637.458 µs) : 0, 637
Telemetry [baseline] (5.707 ms) : 0, 5707
Telemetry [candidate] (5.705 ms) : 0, 5705
section iast
BytebuddyAgent [baseline] (767.183 ms) : 0, 767183
BytebuddyAgent [candidate] (773.643 ms) : 0, 773643
GlobalTracer [baseline] (272.416 ms) : 0, 272416
GlobalTracer [candidate] (274.725 ms) : 0, 274725
AppSec [baseline] (47.148 ms) : 0, 47148
AppSec [candidate] (47.975 ms) : 0, 47975
Remote Config [baseline] (610.868 µs) : 0, 611
Remote Config [candidate] (585.127 µs) : 0, 585
Telemetry [baseline] (8.327 ms) : 0, 8327
Telemetry [candidate] (8.311 ms) : 0, 8311
IAST [baseline] (17.242 ms) : 0, 17242
IAST [candidate] (14.503 ms) : 0, 14503
section profiling
BytebuddyAgent [baseline] (649.159 ms) : 0, 649159
BytebuddyAgent [candidate] (651.694 ms) : 0, 651694
GlobalTracer [baseline] (356.64 ms) : 0, 356640
GlobalTracer [candidate] (356.561 ms) : 0, 356561
AppSec [baseline] (49.472 ms) : 0, 49472
AppSec [candidate] (49.275 ms) : 0, 49275
Remote Config [baseline] (639.518 µs) : 0, 640
Remote Config [candidate] (682.636 µs) : 0, 683
Telemetry [baseline] (6.042 ms) : 0, 6042
Telemetry [candidate] (6.097 ms) : 0, 6097
ProfilingAgent [baseline] (80.375 ms) : 0, 80375
ProfilingAgent [candidate] (81.029 ms) : 0, 81029
Profiling [baseline] (80.398 ms) : 0, 80398
Profiling [candidate] (81.053 ms) : 0, 81053
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019026
Total [baseline] (8.687 s) : 0, 8686527
Agent [candidate] (1.027 s) : 0, 1027130
Total [candidate] (8.722 s) : 0, 8722142
section iast
Agent [baseline] (1.147 s) : 0, 1146780
Total [baseline] (9.259 s) : 0, 9259299
Agent [candidate] (1.146 s) : 0, 1146329
Total [candidate] (9.212 s) : 0, 9212040
section iast_TELEMETRY_OFF
Agent [baseline] (1.139 s) : 0, 1138536
Total [baseline] (9.194 s) : 0, 9193644
Agent [candidate] (1.14 s) : 0, 1139638
Total [candidate] (9.223 s) : 0, 9223470
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent iast 1.147 s 127.754 ms (12.5%)
Agent iast_TELEMETRY_OFF 1.139 s 119.51 ms (11.7%)
Total tracing 8.687 s -
Total iast 9.259 s 572.772 ms (6.6%)
Total iast_TELEMETRY_OFF 9.194 s 507.117 ms (5.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent iast 1.146 s 119.2 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.14 s 112.509 ms (11.0%)
Total tracing 8.722 s -
Total iast 9.212 s 489.899 ms (5.6%)
Total iast_TELEMETRY_OFF 9.223 s 501.328 ms (5.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (635.683 ms) : 0, 635683
BytebuddyAgent [candidate] (641.588 ms) : 0, 641588
GlobalTracer [baseline] (292.628 ms) : 0, 292628
GlobalTracer [candidate] (294.483 ms) : 0, 294483
AppSec [baseline] (49.52 ms) : 0, 49520
AppSec [candidate] (49.657 ms) : 0, 49657
Remote Config [baseline] (680.007 µs) : 0, 680
Remote Config [candidate] (691.099 µs) : 0, 691
Telemetry [baseline] (6.113 ms) : 0, 6113
Telemetry [candidate] (6.132 ms) : 0, 6132
section iast
BytebuddyAgent [baseline] (767.172 ms) : 0, 767172
BytebuddyAgent [candidate] (766.872 ms) : 0, 766872
GlobalTracer [baseline] (271.945 ms) : 0, 271945
GlobalTracer [candidate] (272.051 ms) : 0, 272051
AppSec [baseline] (46.228 ms) : 0, 46228
AppSec [candidate] (46.922 ms) : 0, 46922
IAST [baseline] (16.678 ms) : 0, 16678
IAST [candidate] (17.227 ms) : 0, 17227
Remote Config [baseline] (602.722 µs) : 0, 603
Remote Config [candidate] (588.746 µs) : 0, 589
Telemetry [baseline] (9.716 ms) : 0, 9716
Telemetry [candidate] (8.255 ms) : 0, 8255
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (761.218 ms) : 0, 761218
BytebuddyAgent [candidate] (761.025 ms) : 0, 761025
GlobalTracer [baseline] (272.314 ms) : 0, 272314
GlobalTracer [candidate] (272.86 ms) : 0, 272860
AppSec [baseline] (46.193 ms) : 0, 46193
AppSec [candidate] (46.277 ms) : 0, 46277
IAST [baseline] (15.489 ms) : 0, 15489
IAST [candidate] (16.257 ms) : 0, 16257
Remote Config [baseline] (627.029 µs) : 0, 627
Remote Config [candidate] (539.685 µs) : 0, 540
Telemetry [baseline] (8.29 ms) : 0, 8290
Telemetry [candidate] (8.239 ms) : 0, 8239
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~9ae368faea 1.22.0-SNAPSHOT~339e24bd87
config baseline candidate
end_time 2023-10-26T09:09:55 2023-10-26T09:26:14
start_time 2023-10-26T09:09:43 2023-10-26T09:26:01
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.338 ms) : 1318, 1357
.   : milestone, 1338,
appsec (1.714 ms) : 1690, 1739
.   : milestone, 1714,
iast (1.477 ms) : 1453, 1501
.   : milestone, 1477,
profiling (1.461 ms) : 1436, 1486
.   : milestone, 1461,
tracing (1.453 ms) : 1429, 1478
.   : milestone, 1453,
section candidate
no_agent (1.335 ms) : 1315, 1354
.   : milestone, 1335,
appsec (1.705 ms) : 1681, 1730
.   : milestone, 1705,
iast (1.459 ms) : 1434, 1483
.   : milestone, 1459,
profiling (1.473 ms) : 1447, 1500
.   : milestone, 1473,
tracing (1.48 ms) : 1456, 1504
.   : milestone, 1480,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.338 ms [1.318 ms, 1.357 ms] -
appsec 1.714 ms [1.69 ms, 1.739 ms] 376.722 µs (28.2%)
iast 1.477 ms [1.453 ms, 1.501 ms] 139.264 µs (10.4%)
profiling 1.461 ms [1.436 ms, 1.486 ms] 123.716 µs (9.2%)
tracing 1.453 ms [1.429 ms, 1.478 ms] 115.508 µs (8.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.335 ms [1.315 ms, 1.354 ms] -
appsec 1.705 ms [1.681 ms, 1.73 ms] 370.567 µs (27.8%)
iast 1.459 ms [1.434 ms, 1.483 ms] 123.91 µs (9.3%)
profiling 1.473 ms [1.447 ms, 1.5 ms] 138.655 µs (10.4%)
tracing 1.48 ms [1.456 ms, 1.504 ms] 145.209 µs (10.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~339e24bd87, baseline=1.22.0-SNAPSHOT~9ae368faea
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.106 µs) : 346, 386
.   : milestone, 366,
iast (462.134 µs) : 442, 483
.   : milestone, 462,
iast_FULL (522.688 µs) : 502, 543
.   : milestone, 523,
iast_INACTIVE (438.143 µs) : 417, 459
.   : milestone, 438,
iast_TELEMETRY_OFF (461.583 µs) : 440, 483
.   : milestone, 462,
tracing (433.379 µs) : 413, 454
.   : milestone, 433,
section candidate
no_agent (371.687 µs) : 351, 393
.   : milestone, 372,
iast (461.403 µs) : 441, 482
.   : milestone, 461,
iast_FULL (523.478 µs) : 503, 544
.   : milestone, 523,
iast_INACTIVE (442.567 µs) : 421, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (462.232 µs) : 441, 483
.   : milestone, 462,
tracing (432.178 µs) : 411, 453
.   : milestone, 432,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.106 µs [346.154 µs, 386.057 µs] -
iast 462.134 µs [441.661 µs, 482.607 µs] 96.028 µs (26.2%)
iast_FULL 522.688 µs [502.352 µs, 543.024 µs] 156.582 µs (42.8%)
iast_INACTIVE 438.143 µs [416.98 µs, 459.306 µs] 72.037 µs (19.7%)
iast_TELEMETRY_OFF 461.583 µs [440.216 µs, 482.95 µs] 95.477 µs (26.1%)
tracing 433.379 µs [412.542 µs, 454.217 µs] 67.274 µs (18.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 371.687 µs [350.795 µs, 392.579 µs] -
iast 461.403 µs [440.567 µs, 482.239 µs] 89.716 µs (24.1%)
iast_FULL 523.478 µs [502.713 µs, 544.242 µs] 151.791 µs (40.8%)
iast_INACTIVE 442.567 µs [421.099 µs, 464.034 µs] 70.88 µs (19.1%)
iast_TELEMETRY_OFF 462.232 µs [441.35 µs, 483.114 µs] 90.545 µs (24.4%)
tracing 432.178 µs [411.356 µs, 453.001 µs] 60.491 µs (16.3%)

@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 26, 2023
shatzi
shatzi approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@shatzi shatzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job

@jpbempel jpbempel merged commit 0f5ae07 into master Nov 1, 2023
71 checks passed
@jpbempel jpbempel deleted the jpbempel/change-redacted-values branch November 1, 2023 08:38
@github-actions github-actions bot added this to the 1.23.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

@cimi cimi Awaiting requested review from cimi cimi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi