-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle dependencies #7365
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 8 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (386.149 µs) : 241, 531
. : milestone, 386,
basic (346.281 µs) : 325, 368
. : milestone, 346,
loop (11.656 ms) : 11578, 11735
. : milestone, 11656,
section candidate
noprobe (359.247 µs) : 282, 436
. : milestone, 359,
basic (349.8 µs) : 337, 363
. : milestone, 350,
loop (10.898 ms) : 10833, 10964
. : milestone, 10898,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045084
Total [baseline] (10.36 s) : 0, 10360072
Agent [candidate] (1.046 s) : 0, 1045558
Total [candidate] (10.366 s) : 0, 10365899
section appsec
Agent [baseline] (1.166 s) : 0, 1165571
Total [baseline] (10.494 s) : 0, 10494133
Agent [candidate] (1.166 s) : 0, 1165995
Total [candidate] (10.456 s) : 0, 10455908
section iast
Agent [baseline] (1.172 s) : 0, 1171812
Total [baseline] (10.774 s) : 0, 10773501
Agent [candidate] (1.183 s) : 0, 1183192
Total [candidate] (10.833 s) : 0, 10832611
section profiling
Agent [baseline] (1.241 s) : 0, 1241305
Total [baseline] (10.6 s) : 0, 10599748
Agent [candidate] (1.249 s) : 0, 1249315
Total [candidate] (10.589 s) : 0, 10588780
gantt
title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.18 ms) : 0, 668180
BytebuddyAgent [candidate] (668.102 ms) : 0, 668102
GlobalTracer [baseline] (305.125 ms) : 0, 305125
GlobalTracer [candidate] (305.621 ms) : 0, 305621
AppSec [baseline] (49.979 ms) : 0, 49979
AppSec [candidate] (50.0 ms) : 0, 50000
Remote Config [baseline] (785.42 µs) : 0, 785
Remote Config [candidate] (749.413 µs) : 0, 749
Telemetry [baseline] (7.498 ms) : 0, 7498
Telemetry [candidate] (7.572 ms) : 0, 7572
section appsec
BytebuddyAgent [baseline] (677.991 ms) : 0, 677991
BytebuddyAgent [candidate] (678.275 ms) : 0, 678275
GlobalTracer [baseline] (298.799 ms) : 0, 298799
GlobalTracer [candidate] (299.833 ms) : 0, 299833
AppSec [baseline] (155.476 ms) : 0, 155476
AppSec [candidate] (154.342 ms) : 0, 154342
Remote Config [baseline] (632.23 µs) : 0, 632
Remote Config [candidate] (632.101 µs) : 0, 632
Telemetry [baseline] (8.314 ms) : 0, 8314
Telemetry [candidate] (7.922 ms) : 0, 7922
IAST [baseline] (21.638 ms) : 0, 21638
IAST [candidate] (22.867 ms) : 0, 22867
section iast
BytebuddyAgent [baseline] (781.162 ms) : 0, 781162
BytebuddyAgent [candidate] (787.911 ms) : 0, 787911
GlobalTracer [baseline] (295.031 ms) : 0, 295031
GlobalTracer [candidate] (297.242 ms) : 0, 297242
AppSec [baseline] (48.012 ms) : 0, 48012
AppSec [candidate] (48.362 ms) : 0, 48362
Remote Config [baseline] (578.897 µs) : 0, 579
Remote Config [candidate] (586.833 µs) : 0, 587
Telemetry [baseline] (7.043 ms) : 0, 7043
Telemetry [candidate] (7.957 ms) : 0, 7957
IAST [baseline] (26.475 ms) : 0, 26475
IAST [candidate] (27.507 ms) : 0, 27507
section profiling
BytebuddyAgent [baseline] (663.234 ms) : 0, 663234
BytebuddyAgent [candidate] (667.895 ms) : 0, 667895
GlobalTracer [baseline] (387.261 ms) : 0, 387261
GlobalTracer [candidate] (390.033 ms) : 0, 390033
AppSec [baseline] (51.603 ms) : 0, 51603
AppSec [candidate] (51.411 ms) : 0, 51411
Remote Config [baseline] (646.6 µs) : 0, 647
Remote Config [candidate] (660.523 µs) : 0, 661
Telemetry [baseline] (7.345 ms) : 0, 7345
Telemetry [candidate] (7.366 ms) : 0, 7366
ProfilingAgent [baseline] (94.425 ms) : 0, 94425
ProfilingAgent [candidate] (94.746 ms) : 0, 94746
Profiling [baseline] (94.449 ms) : 0, 94449
Profiling [candidate] (94.77 ms) : 0, 94770
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045649
Total [baseline] (8.492 s) : 0, 8492238
Agent [candidate] (1.046 s) : 0, 1045909
Total [candidate] (8.498 s) : 0, 8498020
section iast
Agent [baseline] (1.185 s) : 0, 1184886
Total [baseline] (9.012 s) : 0, 9011978
Agent [candidate] (1.184 s) : 0, 1184356
Total [candidate] (8.986 s) : 0, 8985563
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.185 s) : 0, 1184661
Total [baseline] (8.965 s) : 0, 8964930
Agent [candidate] (1.182 s) : 0, 1182437
Total [candidate] (8.934 s) : 0, 8934273
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180371
Total [baseline] (8.969 s) : 0, 8968885
Agent [candidate] (1.169 s) : 0, 1169332
Total [candidate] (8.967 s) : 0, 8966563
gantt
title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.444 ms) : 0, 667444
BytebuddyAgent [candidate] (668.181 ms) : 0, 668181
GlobalTracer [baseline] (306.246 ms) : 0, 306246
GlobalTracer [candidate] (305.983 ms) : 0, 305983
AppSec [baseline] (50.237 ms) : 0, 50237
AppSec [candidate] (49.939 ms) : 0, 49939
Remote Config [baseline] (787.868 µs) : 0, 788
Remote Config [candidate] (722.097 µs) : 0, 722
Telemetry [baseline] (7.544 ms) : 0, 7544
Telemetry [candidate] (7.611 ms) : 0, 7611
section iast
BytebuddyAgent [baseline] (791.767 ms) : 0, 791767
BytebuddyAgent [candidate] (790.045 ms) : 0, 790045
GlobalTracer [baseline] (297.87 ms) : 0, 297870
GlobalTracer [candidate] (297.625 ms) : 0, 297625
AppSec [baseline] (50.819 ms) : 0, 50819
AppSec [candidate] (51.419 ms) : 0, 51419
Remote Config [baseline] (584.38 µs) : 0, 584
Remote Config [candidate] (659.121 µs) : 0, 659
Telemetry [baseline] (7.211 ms) : 0, 7211
Telemetry [candidate] (7.253 ms) : 0, 7253
IAST [baseline] (23.004 ms) : 0, 23004
IAST [candidate] (23.731 ms) : 0, 23731
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (793.042 ms) : 0, 793042
BytebuddyAgent [candidate] (788.287 ms) : 0, 788287
GlobalTracer [baseline] (297.438 ms) : 0, 297438
GlobalTracer [candidate] (297.504 ms) : 0, 297504
AppSec [baseline] (49.942 ms) : 0, 49942
AppSec [candidate] (52.088 ms) : 0, 52088
Remote Config [baseline] (572.7 µs) : 0, 573
Remote Config [candidate] (567.204 µs) : 0, 567
Telemetry [baseline] (7.153 ms) : 0, 7153
Telemetry [candidate] (7.795 ms) : 0, 7795
IAST [baseline] (22.858 ms) : 0, 22858
IAST [candidate] (22.609 ms) : 0, 22609
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (785.923 ms) : 0, 785923
BytebuddyAgent [candidate] (780.434 ms) : 0, 780434
GlobalTracer [baseline] (298.195 ms) : 0, 298195
GlobalTracer [candidate] (296.082 ms) : 0, 296082
AppSec [baseline] (47.853 ms) : 0, 47853
AppSec [candidate] (47.388 ms) : 0, 47388
Remote Config [baseline] (585.869 µs) : 0, 586
Remote Config [candidate] (605.212 µs) : 0, 605
Telemetry [baseline] (6.944 ms) : 0, 6944
Telemetry [candidate] (7.038 ms) : 0, 7038
IAST [baseline] (27.24 ms) : 0, 27240
IAST [candidate] (24.232 ms) : 0, 24232
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 22 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section baseline
no_agent (1.71 ms) : 1685, 1735
. : milestone, 1710,
appsec (2.17 ms) : 2139, 2202
. : milestone, 2170,
appsec_no_iast (2.165 ms) : 2135, 2196
. : milestone, 2165,
iast (1.845 ms) : 1815, 1874
. : milestone, 1845,
profiling (1.937 ms) : 1900, 1974
. : milestone, 1937,
tracing (1.868 ms) : 1836, 1900
. : milestone, 1868,
section candidate
no_agent (1.693 ms) : 1668, 1719
. : milestone, 1693,
appsec (2.178 ms) : 2146, 2210
. : milestone, 2178,
appsec_no_iast (2.188 ms) : 2156, 2219
. : milestone, 2188,
iast (1.866 ms) : 1837, 1896
. : milestone, 1866,
profiling (1.976 ms) : 1939, 2012
. : milestone, 1976,
tracing (1.866 ms) : 1834, 1898
. : milestone, 1866,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section baseline
no_agent (448.921 µs) : 420, 478
. : milestone, 449,
iast (587.592 µs) : 555, 620
. : milestone, 588,
iast_FULL (674.778 µs) : 642, 708
. : milestone, 675,
iast_GLOBAL (625.288 µs) : 592, 658
. : milestone, 625,
iast_HARDCODED_SECRET_DISABLED (581.554 µs) : 551, 613
. : milestone, 582,
iast_INACTIVE (552.826 µs) : 521, 584
. : milestone, 553,
iast_TELEMETRY_OFF (570.082 µs) : 538, 602
. : milestone, 570,
tracing (534.686 µs) : 505, 564
. : milestone, 535,
section candidate
no_agent (441.905 µs) : 413, 470
. : milestone, 442,
iast (583.468 µs) : 550, 617
. : milestone, 583,
iast_FULL (676.943 µs) : 646, 708
. : milestone, 677,
iast_GLOBAL (615.018 µs) : 582, 648
. : milestone, 615,
iast_HARDCODED_SECRET_DISABLED (582.557 µs) : 551, 614
. : milestone, 583,
iast_INACTIVE (548.548 µs) : 517, 580
. : milestone, 549,
iast_TELEMETRY_OFF (578.072 µs) : 546, 610
. : milestone, 578,
tracing (535.305 µs) : 506, 565
. : milestone, 535,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section baseline
no_agent (1.548 ms) : 1535, 1561
. : milestone, 1548,
appsec (2.73 ms) : 2667, 2794
. : milestone, 2730,
iast (2.359 ms) : 2287, 2431
. : milestone, 2359,
iast_GLOBAL (2.415 ms) : 2341, 2490
. : milestone, 2415,
profiling (2.22 ms) : 2158, 2281
. : milestone, 2220,
tracing (2.181 ms) : 2122, 2240
. : milestone, 2181,
section candidate
no_agent (1.534 ms) : 1521, 1546
. : milestone, 1534,
appsec (2.707 ms) : 2645, 2769
. : milestone, 2707,
iast (2.374 ms) : 2300, 2448
. : milestone, 2374,
iast_GLOBAL (2.391 ms) : 2319, 2462
. : milestone, 2391,
profiling (2.215 ms) : 2153, 2276
. : milestone, 2215,
tracing (2.18 ms) : 2121, 2239
. : milestone, 2180,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c4c8822055, baseline=1.38.0-SNAPSHOT~0bbb077d19
dateFormat X
axisFormat %s
section baseline
no_agent (21.497 s) : 21497000, 21497000
. : milestone, 21497000,
appsec (21.51 s) : 21510000, 21510000
. : milestone, 21510000,
iast (24.831 s) : 24831000, 24831000
. : milestone, 24831000,
iast_GLOBAL (25.409 s) : 25409000, 25409000
. : milestone, 25409000,
profiling (21.475 s) : 21475000, 21475000
. : milestone, 21475000,
tracing (20.827 s) : 20827000, 20827000
. : milestone, 20827000,
section candidate
no_agent (20.517 s) : 20517000, 20517000
. : milestone, 20517000,
appsec (21.062 s) : 21062000, 21062000
. : milestone, 21062000,
iast (24.636 s) : 24636000, 24636000
. : milestone, 24636000,
iast_GLOBAL (24.896 s) : 24896000, 24896000
. : milestone, 24896000,
profiling (20.824 s) : 20824000, 20824000
. : milestone, 20824000,
tracing (20.496 s) : 20496000, 20496000
. : milestone, 20496000,
|
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
@@ -44,7 +44,7 @@ com.google.protobuf:protobuf-java:3.11.4=jmhRuntimeClasspath,latestDepJava11Test | |||
com.google.re2j:re2j:1.7=instrumentPluginClasspath,jmhRuntimeClasspath,latestDepJava11TestRuntimeClasspath,latestDepTestRuntimeClasspath,muzzleTooling,oldH2TestRuntimeClasspath,oldPostgresTestRuntimeClasspath,runtimeClasspath,testFixturesRuntimeClasspath,testRuntimeClasspath | |||
com.h2database:h2:1.3.168=oldH2TestCompileClasspath,oldH2TestRuntimeClasspath | |||
com.h2database:h2:1.3.169=jmhRuntimeClasspath,oldPostgresTestCompileClasspath,oldPostgresTestRuntimeClasspath,testCompileClasspath,testRuntimeClasspath | |||
com.h2database:h2:2.2.224=latestDepJava11TestCompileClasspath,latestDepJava11TestRuntimeClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath | |||
com.h2database:h2:2.3.230=latestDepJava11TestCompileClasspath,latestDepJava11TestRuntimeClasspath,latestDepTestCompileClasspath,latestDepTestRuntimeClasspath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this newer version, support for Java 8 was dropped:
h2database/h2database#3879
We are trying to use a ctor with 6 int args, and this is only available since v4.1.52 it was introduced in netty/netty#10267
@@ -131,7 +131,7 @@ io.netty:netty-all:4.1.17.Final=compileClasspath,testCompileClasspath,testRuntim | |||
io.netty:netty-all:4.1.47.Final=test_spark24CompileClasspath,test_spark24RuntimeClasspath | |||
io.netty:netty-all:4.1.68.Final=test_spark32CompileClasspath,test_spark32RuntimeClasspath | |||
io.netty:netty-all:4.1.96.Final=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath | |||
io.netty:netty-buffer:4.1.50.Final=test_spark32CompileClasspath,test_spark32RuntimeClasspath | |||
io.netty:netty-buffer:4.1.52.Final=test_spark32CompileClasspath,test_spark32RuntimeClasspath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error we are getting with 4.1.50 is java.lang.NoSuchMethodError: 'void io.netty.buffer.PooledByteBufAllocator.<init>(boolean, int, int, int, int, int, int, boolean)'
This "6 int" constructor was introduced in netty/netty#10267 and is only available in v4.1.52 onwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates the Gradle dependencies.
⚠️ Don't forget to squash commits before merging ⚠️