diff --git a/.github/workflows/prof_asan.yml b/.github/workflows/prof_asan.yml index c92afcf241..6fb4cb4a81 100644 --- a/.github/workflows/prof_asan.yml +++ b/.github/workflows/prof_asan.yml @@ -7,7 +7,7 @@ jobs: prof-asan: runs-on: ubuntu-latest container: - image: datadog/dd-trace-ci:php-8.3_bookworm-2 + image: datadog/dd-trace-ci:php-8.3_bookworm-3 # https://docs.github.com/en/actions/creating-actions/dockerfile-support-for-github-actions#user options: --user root --privileged diff --git a/docker-compose.yml b/docker-compose.yml index 211266e53b..7f7d7c72d5 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -83,7 +83,7 @@ services: '8.3-buster': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-8.3_buster' } 'php-master-buster': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-master_buster' } # --- Bookworm --- - '8.3-bookworm': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-8.3_bookworm-2' } + '8.3-bookworm': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-8.3_bookworm-3' } # --- CentOS 6 --- '7.0-centos7': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-7.0_centos-7' } '7.1-centos7': { <<: *linux_php_service, image: 'datadog/dd-trace-ci:php-7.1_centos-7' } diff --git a/dockerfiles/ci/alpine_compile_extension/docker-compose.yml b/dockerfiles/ci/alpine_compile_extension/docker-compose.yml index 16ce19be8b..31d034a400 100644 --- a/dockerfiles/ci/alpine_compile_extension/docker-compose.yml +++ b/dockerfiles/ci/alpine_compile_extension/docker-compose.yml @@ -92,8 +92,8 @@ services: context: . x-bake: *bake args: - php_version: 8.1.26 - php_sha: d954cecfc3d294c2fccbe2b1a6bef784ce0d6c5d44a9e28f8a527e092825f2cb + php_version: 8.1.29 + php_sha: 8b2609bf1d3173aa38269a9af21532c65f730aadd3051f9aae011eea9e246de5 php_api: 20210902 volumes: - ../../:/app @@ -104,8 +104,8 @@ services: context: . x-bake: *bake args: - php_version: 8.2.13 - php_sha: 6a194038f5a9e46d8f70a9d59c072c3b08d6edbdd8e304096e24ccf2225bcf1b + php_version: 8.2.21 + php_sha: 0c6323699309a4d2e71057f01bc071b199f240973c349287b667a3ab36a496c6 php_api: 20220829 volumes: - ../../:/app @@ -116,9 +116,8 @@ services: context: . x-bake: *bake args: - php_version: 8.3.0 - php_url: https://www.php.net/distributions/php-8.3.0.tar.gz - php_sha: "557ae14650f1d1984d3213e3fcd8d93a5f11418b3f8026d3a2d5022251163951" + php_version: 8.3.9 + php_sha: f484dec6ee005c83f899af02fc021e1bc3b1d7b3f143ca062ef66b0fcee96566 php_api: 20230831 volumes: - ../../:/app diff --git a/dockerfiles/ci/bookworm/.env b/dockerfiles/ci/bookworm/.env index 968843d460..8f87f82ebe 100644 --- a/dockerfiles/ci/bookworm/.env +++ b/dockerfiles/ci/bookworm/.env @@ -1,2 +1,2 @@ -BOOKWORM_CURRENT_VERSION=2 -BOOKWORM_NEXT_VERSION=3 +BOOKWORM_CURRENT_VERSION=3 +BOOKWORM_NEXT_VERSION=4 diff --git a/dockerfiles/ci/bookworm/docker-compose.yml b/dockerfiles/ci/bookworm/docker-compose.yml index 82ca6a477e..7919c55546 100644 --- a/dockerfiles/ci/bookworm/docker-compose.yml +++ b/dockerfiles/ci/bookworm/docker-compose.yml @@ -22,8 +22,8 @@ services: args: <<: *build-base phpVersion: "8.3" - phpTarGzUrl: https://www.php.net/distributions/php-8.3.0.tar.gz - phpSha256Hash: "557ae14650f1d1984d3213e3fcd8d93a5f11418b3f8026d3a2d5022251163951" + phpTarGzUrl: https://www.php.net/distributions/php-8.3.9.tar.gz + phpSha256Hash: "f484dec6ee005c83f899af02fc021e1bc3b1d7b3f143ca062ef66b0fcee96566" php-8.2: image: datadog/dd-trace-ci:php-8.2_bookworm-$BOOKWORM_NEXT_VERSION @@ -34,8 +34,8 @@ services: args: <<: *build-base phpVersion: "8.2" - phpTarGzUrl: https://www.php.net/distributions/php-8.2.13.tar.gz - phpSha256Hash: "6a194038f5a9e46d8f70a9d59c072c3b08d6edbdd8e304096e24ccf2225bcf1b" + phpTarGzUrl: https://www.php.net/distributions/php-8.2.21.tar.gz + phpSha256Hash: "0c6323699309a4d2e71057f01bc071b199f240973c349287b667a3ab36a496c6" php-8.1: image: datadog/dd-trace-ci:php-8.1_bookworm-$BOOKWORM_NEXT_VERSION @@ -46,8 +46,8 @@ services: args: <<: *build-base phpVersion: "8.1" - phpTarGzUrl: https://www.php.net/distributions/php-8.1.26.tar.gz - phpSha256Hash: "d954cecfc3d294c2fccbe2b1a6bef784ce0d6c5d44a9e28f8a527e092825f2cb" + phpTarGzUrl: https://www.php.net/distributions/php-8.1.29.tar.gz + phpSha256Hash: "8b2609bf1d3173aa38269a9af21532c65f730aadd3051f9aae011eea9e246de5" php-8.0: image: datadog/dd-trace-ci:php-8.0_bookworm-$BOOKWORM_NEXT_VERSION diff --git a/dockerfiles/ci/buster/docker-compose.yml b/dockerfiles/ci/buster/docker-compose.yml index 5537275354..9ca7767fa5 100644 --- a/dockerfiles/ci/buster/docker-compose.yml +++ b/dockerfiles/ci/buster/docker-compose.yml @@ -19,8 +19,8 @@ services: x-bake: *bake args: phpVersion: "8.3" - phpTarGzUrl: https://www.php.net/distributions/php-8.3.0.tar.gz - phpSha256Hash: "557ae14650f1d1984d3213e3fcd8d93a5f11418b3f8026d3a2d5022251163951" + phpTarGzUrl: https://www.php.net/distributions/php-8.3.9.tar.gz + phpSha256Hash: "f484dec6ee005c83f899af02fc021e1bc3b1d7b3f143ca062ef66b0fcee96566" php-8.2: image: datadog/dd-trace-ci:php-8.2_buster @@ -30,8 +30,8 @@ services: x-bake: *bake args: phpVersion: "8.2" - phpTarGzUrl: https://www.php.net/distributions/php-8.2.17.tar.gz - phpSha256Hash: "1d8ab98e1c09518c672c5afcbef0e61f9003173c7638fc686461ae670d12742e" + phpTarGzUrl: https://www.php.net/distributions/php-8.2.21.tar.gz + phpSha256Hash: "0c6323699309a4d2e71057f01bc071b199f240973c349287b667a3ab36a496c6" php-8.1: image: datadog/dd-trace-ci:php-8.1_buster @@ -41,8 +41,8 @@ services: x-bake: *bake args: phpVersion: "8.1" - phpTarGzUrl: https://www.php.net/distributions/php-8.1.26.tar.gz - phpSha256Hash: "d954cecfc3d294c2fccbe2b1a6bef784ce0d6c5d44a9e28f8a527e092825f2cb" + phpTarGzUrl: https://www.php.net/distributions/php-8.1.29.tar.gz + phpSha256Hash: "8b2609bf1d3173aa38269a9af21532c65f730aadd3051f9aae011eea9e246de5" php-8.0: image: datadog/dd-trace-ci:php-8.0_buster diff --git a/dockerfiles/ci/centos/7/docker-compose.yml b/dockerfiles/ci/centos/7/docker-compose.yml index f92650e5f7..cdedb1d81b 100644 --- a/dockerfiles/ci/centos/7/docker-compose.yml +++ b/dockerfiles/ci/centos/7/docker-compose.yml @@ -84,8 +84,8 @@ services: x-bake: *bake args: phpVersion: "8.1" - phpTarGzUrl: https://www.php.net/distributions/php-8.1.26.tar.gz - phpSha256Hash: d954cecfc3d294c2fccbe2b1a6bef784ce0d6c5d44a9e28f8a527e092825f2cb + phpTarGzUrl: https://www.php.net/distributions/php-8.1.29.tar.gz + phpSha256Hash: "8b2609bf1d3173aa38269a9af21532c65f730aadd3051f9aae011eea9e246de5" image: 'datadog/dd-trace-ci:php-8.1_centos-7' php-8.2: @@ -95,8 +95,8 @@ services: x-bake: *bake args: phpVersion: "8.2" - phpTarGzUrl: https://www.php.net/distributions/php-8.2.13.tar.gz - phpSha256Hash: 6a194038f5a9e46d8f70a9d59c072c3b08d6edbdd8e304096e24ccf2225bcf1b + phpTarGzUrl: https://www.php.net/distributions/php-8.2.21.tar.gz + phpSha256Hash: "0c6323699309a4d2e71057f01bc071b199f240973c349287b667a3ab36a496c6" image: 'datadog/dd-trace-ci:php-8.2_centos-7' php-8.3: @@ -106,6 +106,6 @@ services: x-bake: *bake args: phpVersion: "8.3" - phpTarGzUrl: https://www.php.net/distributions/php-8.3.0.tar.gz - phpSha256Hash: 557ae14650f1d1984d3213e3fcd8d93a5f11418b3f8026d3a2d5022251163951 + phpTarGzUrl: https://www.php.net/distributions/php-8.3.9.tar.gz + phpSha256Hash: "f484dec6ee005c83f899af02fc021e1bc3b1d7b3f143ca062ef66b0fcee96566" image: 'datadog/dd-trace-ci:php-8.3_centos-7' diff --git a/dockerfiles/ci/windows/docker-compose.yml b/dockerfiles/ci/windows/docker-compose.yml index a3170aadf2..337cc390bc 100644 --- a/dockerfiles/ci/windows/docker-compose.yml +++ b/dockerfiles/ci/windows/docker-compose.yml @@ -5,24 +5,32 @@ services: vc14-base: image: datadog/dd-trace-ci:windows-base-vc14 build: + platforms: + - windows/amd64 context: . dockerfile: vc14.Dockerfile vc15-base: image: datadog/dd-trace-ci:windows-base-vc15 build: + platforms: + - windows/amd64 context: . dockerfile: vc15.Dockerfile vs16-base: image: datadog/dd-trace-ci:windows-base-vs16 build: + platforms: + - windows/amd64 context: . dockerfile: vs16.Dockerfile vc14: image: datadog/dd-trace-ci:windows-vc14 build: + platforms: + - windows/amd64 context: . dockerfile: basetools.Dockerfile args: @@ -32,6 +40,8 @@ services: vc15: image: datadog/dd-trace-ci:windows-vc15 build: + platforms: + - windows/amd64 context: . dockerfile: basetools.Dockerfile args: @@ -41,6 +51,8 @@ services: vs16: image: datadog/dd-trace-ci:windows-vs16 build: + platforms: + - windows/amd64 context: . dockerfile: basetools.Dockerfile args: @@ -50,36 +62,44 @@ services: php-8.3: image: datadog/dd-trace-ci:php-8.3_windows build: + platforms: + - windows/amd64 context: . args: - phpVersion: "8.3.0" + phpVersion: "8.3.9" vsVersion: "vs16" - phpTarGzUrl: https://www.php.net/distributions/php-8.3.0.tar.gz - phpSha256Hash: "557ae14650f1d1984d3213e3fcd8d93a5f11418b3f8026d3a2d5022251163951" + phpTarGzUrl: https://www.php.net/distributions/php-8.3.9.tar.gz + phpSha256Hash: "f484dec6ee005c83f899af02fc021e1bc3b1d7b3f143ca062ef66b0fcee96566" php-8.2: image: datadog/dd-trace-ci:php-8.2_windows build: + platforms: + - windows/amd64 context: . args: - phpVersion: "8.2.6" + phpVersion: "8.2.21" vsVersion: "vs16" - phpTarGzUrl: https://www.php.net/distributions/php-8.2.6.tar.gz - phpSha256Hash: "1b8463df1f180ed39475cfcded1ff106242ccb823f99c9fc1a407c0b76afa2c8" + phpTarGzUrl: https://www.php.net/distributions/php-8.2.21.tar.gz + phpSha256Hash: "0c6323699309a4d2e71057f01bc071b199f240973c349287b667a3ab36a496c6" php-8.1: image: datadog/dd-trace-ci:php-8.1_windows build: + platforms: + - windows/amd64 context: . args: - phpVersion: "8.1.19" + phpVersion: "8.1.29" vsVersion: "vs16" - phpTarGzUrl: https://www.php.net/distributions/php-8.1.19.tar.gz - phpSha256Hash: "0ebb6b0ecf5d8e355c2f1362807f9b73c6e803d496c5ad3e4fb00be989988372" + phpTarGzUrl: https://www.php.net/distributions/php-8.1.29.tar.gz + phpSha256Hash: "8b2609bf1d3173aa38269a9af21532c65f730aadd3051f9aae011eea9e246de5" php-8.0: image: datadog/dd-trace-ci:php-8.0_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "8.0.28" @@ -90,6 +110,8 @@ services: php-7.4: image: datadog/dd-trace-ci:php-7.4_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "7.4.33" @@ -100,6 +122,8 @@ services: php-7.3: image: datadog/dd-trace-ci:php-7.3_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "7.3.33" @@ -110,6 +134,8 @@ services: php-7.2: image: datadog/dd-trace-ci:php-7.2_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "7.2.34" @@ -120,6 +146,8 @@ services: php-7.1: image: datadog/dd-trace-ci:php-7.1_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "7.1.33" @@ -130,6 +158,8 @@ services: php-7.0: image: datadog/dd-trace-ci:php-7.0_windows build: + platforms: + - windows/amd64 context: . args: phpVersion: "7.0.33" diff --git a/dockerfiles/ci/xfail_tests/8.2.list b/dockerfiles/ci/xfail_tests/8.2.list index 8eba936701..4630cafb3a 100644 --- a/dockerfiles/ci/xfail_tests/8.2.list +++ b/dockerfiles/ci/xfail_tests/8.2.list @@ -128,6 +128,7 @@ ext/standard/tests/array/array_reverse_variation4.phpt ext/standard/tests/array/array_unique_variation3.phpt ext/standard/tests/file/bug52820.phpt ext/standard/tests/file/disk_free_space_basic.phpt +ext/standard/tests/file/file_get_contents_file_put_contents_5gb.phpt ext/standard/tests/file/lstat_stat_variation10.phpt ext/standard/tests/filters/bug54350.phpt ext/standard/tests/general_functions/bug73973.phpt diff --git a/dockerfiles/ci/xfail_tests/8.3.list b/dockerfiles/ci/xfail_tests/8.3.list index aca09cb88a..e4b0d92081 100644 --- a/dockerfiles/ci/xfail_tests/8.3.list +++ b/dockerfiles/ci/xfail_tests/8.3.list @@ -130,6 +130,7 @@ ext/standard/tests/array/array_reverse_variation4.phpt ext/standard/tests/array/array_unique_variation3.phpt ext/standard/tests/file/bug52820.phpt ext/standard/tests/file/disk_free_space_basic.phpt +ext/standard/tests/file/file_get_contents_file_put_contents_5gb.phpt ext/standard/tests/file/lstat_stat_variation10.phpt ext/standard/tests/filters/bug54350.phpt ext/standard/tests/general_functions/bug73973.phpt diff --git a/dockerfiles/ci/xfail_tests/README.md b/dockerfiles/ci/xfail_tests/README.md index e3fd0d297d..826bdb2fe6 100644 --- a/dockerfiles/ci/xfail_tests/README.md +++ b/dockerfiles/ci/xfail_tests/README.md @@ -57,6 +57,14 @@ The following tests assert the output of `var_dump($obj)` and fail because we ad # Specific tests +## `ext/standard/tests/file/file_get_contents_file_put_contents_5gb.phpt` + +Disabled on versions: `8.2`, `8.3`. + +Allocates > 5GB of Ram on a CircleCI medium instance (limit 4GB) but uses +`/proc/meminfo` to check if enough memory is available in the `SKIP` section. +See https://github.com/php/php-src/pull/14895 and https://github.com/DataDog/dd-trace-php/pull/2752#issuecomment-2219813169 + ## `sapi/cli/tests/bug80092.phpt` Temporarily disabled due to a too strict of a check for the precise php -v output. diff --git a/ext/hook/uhook.c b/ext/hook/uhook.c index 08d7caa9ae..476179908c 100644 --- a/ext/hook/uhook.c +++ b/ext/hook/uhook.c @@ -448,6 +448,7 @@ static void dd_uhook_end(zend_ulong invocation, zend_execute_data *execute_data, zend_function *orig_func = *(zend_function**)(execute_data->func + 1); efree(execute_data->func); execute_data->func = orig_func; + execute_data->opline = orig_func->op_array.opcodes + orig_func->op_array.last - 1; } else { // TODO: not supported yet (JIT support appearing problematic) }