Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Started seeing failed to extract response cookies ValueError : not enough values to unpack #11818

Open
ukalwa opened this issue Dec 20, 2024 · 1 comment
Open

[BUG]: Started seeing failed to extract response cookies ValueError : not enough values to unpack #11818

ukalwa opened this issue Dec 20, 2024 · 1 comment
Labels
bug

Comments

@ukalwa
Copy link

ukalwa commented Dec 20, 2024

Tracer Version(s)

2.18

Python Version(s)

3.11

Pip Version(s)

24.3.1

Bug Report

Started seeing failed to extract response cookies ValueError : not enough values to unpack when deploying fastapi app with uvicorn and wrapping it with ddtrace-run.

It seems to happen at this line when there is no set-cookie header:

dd-trace-py/ddtrace/contrib/internal/asgi/middleware.py

Lines 239 to 244 in 6ea56c5

cookies = {}
try:
cookie_key, cookie_value = response_headers.get("set-cookie", "").split("=", maxsplit=1)
cookies[cookie_key] = cookie_value
except Exception:
log.debug("failed to extract response cookies", exc_info=True)

Reproduction Code

No response

Error Logs

No response

Libraries in Use

No response

Operating System

No response
@ukalwa ukalwa added the bug label Dec 20, 2024
@ukalwa ukalwa mentioned this issue Dec 20, 2024
Closed
2 tasks
@wantsui
Copy link
Collaborator

wantsui commented Dec 20, 2024 •
edited
Loading

Thanks for the report @ukalwa ! I was also able to reproduce this based on the information you provided.

For now it looks like the failed to extract response cookies message only occurs if the logging module is in DEBUG logging level (which then triggers our tracer to log in debug mode) or ddtrace has debug mode enabled via:DD_TRACE_DEBUG=TRUE . That said, I agree that this is not good behavior.

I'll review next steps with the team (along with your PR).

@avara1986 avara1986 mentioned this issue Dec 23, 2024
Merged
2 tasks
quinna-h pushed a commit that referenced this issue Dec 26, 2024
@avara1986
fix: error parsing response cookies in FastAPI and awsgi (#11829)
e29ccb0 
This fix resolves an issue parsing response cookies in FastAPI and awsgi

issue: #11818

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met 
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
github-actions bot pushed a commit that referenced this issue Dec 26, 2024
@avara1986 @github-actions
fix: error parsing response cookies in FastAPI and awsgi (#11829)
89216be 
This fix resolves an issue parsing response cookies in FastAPI and awsgi

issue: #11818

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit e29ccb0)
@github-actions github-actions bot mentioned this issue Dec 26, 2024
Open
2 tasks
github-actions bot pushed a commit that referenced this issue Dec 26, 2024
@avara1986 @github-actions
fix: error parsing response cookies in FastAPI and awsgi (#11829)
96992a9 
This fix resolves an issue parsing response cookies in FastAPI and awsgi

issue: #11818

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit e29ccb0)
@github-actions github-actions bot mentioned this issue Dec 26, 2024
Open
2 tasks
github-actions bot pushed a commit that referenced this issue Dec 26, 2024
@avara1986 @github-actions
fix: error parsing response cookies in FastAPI and awsgi (#11829)
1571e21 
This fix resolves an issue parsing response cookies in FastAPI and awsgi

issue: #11818

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [x] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit e29ccb0)
@github-actions github-actions bot mentioned this issue Dec 26, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: value error when set-cookie header is not present ukalwa/dd-trace-py
2 participants
@ukalwa @wantsui