revert logger_without_configuration changes

Author: vpellan

lib/datadog/core/configuration.rb

@@ -174,8 +174,8 @@ def logger
 
       # During stable config initialization, we also have to check for DD_TRACE_DEBUG in local and fleet config.
       # We pass the debug source value
-      def config_init_logger(debug_source_value = DATADOG_ENV[Ext::Diagnostics::ENV_DEBUG_ENABLED])
-        configuration? ? logger : logger_without_configuration(debug_source_value)
+      def config_init_logger
+        configuration? ? logger : logger_without_configuration
       end
 
       # Gracefully shuts down all components.
@@ -292,17 +292,17 @@ def logger_without_components
         end
       end
 
-      def logger_without_configuration(debug_source_value)
+      def logger_without_configuration
         # There's rare cases where we need to use logger during configuration initialization,
         # such as reading stable config. In this case we cannot access configuration.
 
         @temp_config_logger ||= begin
-          debug_value = debug_source_value&.strip&.downcase
-          debug = debug_value == 'true' || debug_value == '1'
+          debug_env_value = DATADOG_ENV[Ext::Diagnostics::ENV_DEBUG_ENABLED]&.strip&.downcase
+          debug_value = debug_env_value == 'true' || debug_env_value == '1'
 
           logger = Core::Logger.new($stdout)
           # We cannot access config and the default level is INFO, so we need to set the level manually
-          logger.level = debug ? ::Logger::DEBUG : ::Logger::INFO
+          logger.level = debug_value ? ::Logger::DEBUG : ::Logger::INFO
           logger
         end
       end

sig/datadog/core/configuration.rbs

@@ -9,7 +9,7 @@ module Datadog
 
       def configuration: () -> untyped # The DSL methods have to be explicitly declared for this to be typed
 
-      def config_init_logger: (?String debug_source_value) -> Datadog::Core::Logger
+      def config_init_logger: () -> Datadog::Core::Logger
 
       def shutdown!: -> void
     end

spec/datadog/core/configuration_spec.rb

@@ -448,25 +448,20 @@
     end
 
     describe '#logger_without_configuration' do
-      subject(:logger_without_configuration) { test_class.send(:logger_without_configuration, debug_source_value) }
-
-      context 'when configuration is not initialized and debug_source_value is not set' do
-        let(:debug_source_value) { nil }
-
+      subject(:logger_without_configuration) { test_class.send(:logger_without_configuration) }
+      context 'when configuration is not initialized and DD_TRACE_DEBUG is not set' do
         it { expect(logger_without_configuration.level).to be ::Logger::INFO }
       end
 
-      context 'when configuration is not initialized and debug_source_value is set to true' do
-        let(:debug_source_value) { 'true' }
+      context 'when configuration is not initialized and DD_TRACE_DEBUG is set' do
+        around do |example|
+          ClimateControl.modify('DD_TRACE_DEBUG' => 'true') do
+            example.run
+          end
+        end
 
         it { expect(logger_without_configuration.level).to be ::Logger::DEBUG }
       end
-
-      context 'when configuration is not initialized and debug_source_value is set to false' do
-        let(:debug_source_value) { 'false' }
-
-        it { expect(logger_without_configuration.level).to be ::Logger::INFO }
-      end
     end
 
     describe '#runtime_metrics' do