Skip to content

Commit f158428

Browse files
committed
[NO-TICKET] Re-enable memory leak asan testing in CI
**What does this PR do?** This PR reverts #3915 where we temporarily disable memory leak testing using the asan tool because upstream builds were broken. Additionally, since ruby/setup-ruby#653 the setup-ruby action now fully supports the asan builds, so we no longer require our fork. **Motivation:** The asan tool does quite extensive checks in the profiler test suite, so having it running in CI helps catch issues that may otherwise slip by. **Additional Notes:** N/A **How to test the change?** Validate that the "Test for memory leaks -> test-asan" CI job is running and passing successfully.
1 parent 2cde72a commit f158428

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

.github/workflows/test-memory-leaks.yaml

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,20 +14,10 @@ jobs:
1414
- run: sudo apt-get update && (sudo apt-get install -y valgrind || sleep 5 && sudo apt-get install -y valgrind) && valgrind --version
1515
- run: bundle exec rake compile spec:profiling:memcheck
1616
test-asan:
17-
# Temporarily disabled on 2024-09-17 until ruby-asan builds are available again on
18-
# https://github.com/ruby/ruby-dev-builder/releases
19-
if: false
2017
runs-on: ubuntu-24.04
2118
steps:
2219
- uses: actions/checkout@v4
23-
# We're using a fork of ruby/setup-ruby because the "asan" tool is built into the clang compiler toolchain, and
24-
# needs Ruby to be built with a special configuration.
25-
#
26-
# The special configuration is not yet available in the upstream `ruby/setup-ruby` github action, so I needed to
27-
# fork it and push a small tweak to make it available.
28-
#
29-
# (The Ruby builds were added in https://github.com/ruby/ruby-dev-builder/pull/10 ).
30-
- uses: datadog/setup-ruby@0c7206d6db81faf999795ceebfac00d164298bd5
20+
- uses: ruby/setup-ruby@v1
3121
with:
3222
ruby-version: asan
3323
bundler-cache: true # runs 'bundle install' and caches installed gems automatically

0 commit comments

Comments
 (0)