Skip to content
This repository has been archived by the owner on Oct 21, 2024. It is now read-only.

Ability to create route specific tags #18

Open
nicgirault opened this issue May 29, 2020 · 1 comment · May be fixed by #19
Open

Ability to create route specific tags #18

nicgirault opened this issue May 29, 2020 · 1 comment · May be fixed by #19

Comments

@nicgirault
Copy link

nicgirault commented May 29, 2020

With connect-datadog 0.0.9 it is not possible to add route specific tags. I would like to do so to associate routes to a SLO domain with a tag: domain:my-domain.

I don't see an elegant way to do so. One way would be to adjust this line to read tags that could have been added in middlewares defined after datadog middleware:

let statTags = [...tags, ...req.ddTags]

Would you merge such a PR?

@nicgirault nicgirault linked a pull request May 29, 2020 that will close this issue
@hybby
Copy link

hybby commented Jun 8, 2020

Very interested in the feature proposed by #19 - could someone from Datadog confirm if there's any scope to merge this soon?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants