Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the listed dependencies to those that are actually reachable #126

Open
bruceg opened this issue Mar 11, 2024 · 2 comments
Open

Limit the listed dependencies to those that are actually reachable #126

bruceg opened this issue Mar 11, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bruceg
Copy link
Collaborator

bruceg commented Mar 11, 2024

The data source underlying rust-license-tool lists all entries in the dependency tree, even if they can't be reached under any actual combination of top-level feature flags. While we can't reasonably expand every possible combination of the top-level feature flags (Vector has 228 which leads to about 10^440 unique combinations), we should be able to reduce that dependency tree by producing sets of possible feature flags for each crate and thereby eliminate sub-dependencies that can't be turned on. This would reduce the size of the generated licenses file, producing a more accurate reflection of what components are actually used.

@bruceg bruceg added the enhancement New feature or request label Mar 11, 2024
@jszwedko
Copy link
Collaborator

Is rust-lang/cargo#10801 related to this?

@bruceg
Copy link
Collaborator Author

bruceg commented Mar 11, 2024

Yes, that's the one. I was looking for that link when I wrote the above but couldn't find it. There may be opportunities for us to solve this without support from that issue, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants