Compact before checking buffer length

CharlesMasson · CharlesMasson · commit 47d600901f2c · 2022-01-06T11:26:35.000+01:00
Compacting may cause the buffer to become empty, in which case
there is no need to encode the buffer.
diff --git a/ddsketch/store/buffered_paginated.go b/ddsketch/store/buffered_paginated.go
@@ -570,8 +570,8 @@ func (s *BufferedPaginatedStore) Reweight(w float64) error {
 }
 
 func (s *BufferedPaginatedStore) Encode(b *[]byte, t enc.FlagType) {
+	s.compact()
 	if len(s.buffer) > 0 {
-		s.compact()
 		enc.EncodeFlag(b, enc.NewFlag(t, enc.BinEncodingIndexDeltas))
 		enc.EncodeUvarint64(b, uint64(len(s.buffer)))
 		previousIndex := 0

Original file line number	Diff line number	Diff line change
`@@ -570,8 +570,8 @@ func (s *BufferedPaginatedStore) Reweight(w float64) error {`
`570`	`570`	`}`
`571`	`571`
`572`	`572`	`func (s BufferedPaginatedStore) Encode(b []byte, t enc.FlagType) {`
	`573`	`+ s.compact()`
`573`	`574`	`if len(s.buffer) > 0 {`
`574`		`- s.compact()`
`575`	`575`	`enc.EncodeFlag(b, enc.NewFlag(t, enc.BinEncodingIndexDeltas))`
`576`	`576`	`enc.EncodeUvarint64(b, uint64(len(s.buffer)))`
`577`	`577`	`previousIndex := 0`