Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Istio use config.Env #856

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Istio use config.Env #856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a779eec
Istio use config.Env
nplanel Jun 3, 2024
1fb49e4
Merge branch 'main' into nplanel/istio-config-env
pducolin Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/kubernetes/istio/istio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func NewHelmInstallation(e config.Env, opts ...pulumi.ResourceOption) (*HelmComp
return helmComponent, nil
}

func NewHttpbinServiceInstallation(e config.CommonEnvironment, opts ...pulumi.ResourceOption) (*corev1.Service, error) {
func NewHttpbinServiceInstallation(e config.Env, opts ...pulumi.ResourceOption) (*corev1.Service, error) {
// deploy httpbin on default namespace
httpbinServiceAccount, err := corev1.NewServiceAccount(e.Ctx(), "httpbin", &corev1.ServiceAccountArgs{
Metadata: metav1.ObjectMetaArgs{Name: pulumi.String("httpbin")},
Expand Down Expand Up @@ -195,7 +195,7 @@ func NewHttpbinServiceInstallation(e config.CommonEnvironment, opts ...pulumi.Re
return httpbinService, nil
}

func NewHttpbinGatewayRoutesInstallation(e config.CommonEnvironment, opts ...pulumi.ResourceOption) error {
func NewHttpbinGatewayRoutesInstallation(e config.Env, opts ...pulumi.ResourceOption) error {
// create the gateway
httpbinGateway, err := apiext.NewCustomResource(e.Ctx(), "gateway", &apiext.CustomResourceArgs{
ApiVersion: pulumi.String("networking.istio.io/v1alpha3"),
Expand Down