Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dinky-core] Bug title savepiont [Exception String index out of range 0] #4080

Closed
3 tasks done
MsinChan opened this issue Dec 23, 2024 · 5 comments
Closed
3 tasks done
Labels
Bug Something isn't working

Comments

@MsinChan
Copy link

MsinChan commented Dec 23, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

Exception String index out of range 0
image

What you expected to happen

dinky/dinky-core/src/main/java/org/dinky/api/FlinkAPI.java

url = NetConstant.SLASH + route unspliced address

  private JsonNode post(String route, String body) {
      String url = NetConstant.SLASH + route;
      if (!address.startsWith(NetConstant.HTTP) && !address.startsWith(NetConstant.HTTPS)) {
          url = NetConstant.HTTP + url;
      }
      String res = HttpUtil.post(url, body, NetConstant.SERVER_TIME_OUT_ACTIVE);
      return parse(res);
  }

How to reproduce

image
trigger savepoint and cancel job

Anything else

No response

Version

1.2.0

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@MsinChan MsinChan added Bug Something isn't working Waiting for reply Waiting for reply labels Dec 23, 2024
@MsinChan MsinChan changed the title [Bug] [dinky-core] Bug title savepiont [Exception String index out of range [Bug] [dinky-core] Bug title savepiont [Exception String index out of range 0] Dec 23, 2024
@suqingyang
Copy link

I'm experiencing the same issue as well.

1 similar comment
@Pandas886
Copy link
Contributor

I'm experiencing the same issue as well.

@MactavishCui
Copy link
Contributor

The reason of this bug is that in FlinkAPI line 115

String url = NetConstant.SLASH + route;

address is lost
this line should be

String url = address + NetConstant.SLASH + route;

I'll submit a PR and fix this bug.

@MactavishCui
Copy link
Contributor

The reason of this bug is that in FlinkAPI line 115

String url = NetConstant.SLASH + route;

address is lost this line should be

String url = address + NetConstant.SLASH + route;

I'll submit a PR and fix this bug.

#4105

@aiwenmo aiwenmo removed the Waiting for reply Waiting for reply label Jan 2, 2025
@aiwenmo
Copy link
Contributor

aiwenmo commented Jan 2, 2025

#4108

@aiwenmo aiwenmo closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants