New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] xAxis: Date mismatch in combined charts #181

Open

Daveiano opened this issue Jul 7, 2023 · 0 comments

Labels

bug

Owner

Daveiano commented Jul 7, 2023 •

edited

Loading

A mismatching of the date on the xAxis can be noticed when using the cumulative aggregation:

To investigate

Could be something with start vs end timestamp (https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/src/js/index.tsx#L133)

return {
  x: item[0],
  y: item[2],
  start: item[0],
  end: item[1],
};

Could be something with the xAxis scale (https://github.com/Daveiano/weewx-wdc/blob/3.x/skins/weewx-wdc/src/js/diagrams/d3/combined.tsx#L272)

The text was updated successfully, but these errors were encountered:

Daveiano added the bug label

Daveiano added a commit that referenced this issue


          Reverted using end timestamp for charts. GH-181

11eed6b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment